'Re: Review Request: partialReset doesn't seem to work in the windowstrip'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: partialReset doesn't seem to work in the windowstrip
From:       Martin_Gräßlin <kde () martin-graesslin ! com>
Date:       2012-05-03 7:58:37
Message-ID: 20120503075837.30922.55373 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104119/#review13304
-----------------------------------------------------------

I think we need a better solution here

- Martin Gr=C3=A4=C3=9Flin

On Feb. 29, 2012, 5:23 p.m., Marco Martin wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104119/
> -----------------------------------------------------------
> =

> (Updated Feb. 29, 2012, 5:23 p.m.)
> =

> =

> Review request for kwin.
> =

> =

> Description
> -------
> =

> in the windowstrip if partialreset is chacked, the window strip would cor=
rectly open a couple of times, then only the no windows entry would be pres=
ent, probably due to windows appeared or gone away and the model getting in=
correctly updated.
> =

> if the reset is always complete it works correctly, even tough is not rea=
lly a good solution
> =

> =

> Diffs
> -----
> =

>   kwin/tabbox/clientmodel.cpp 4ca7fef =

> =

> Diff: http://git.reviewboard.kde.org/r/104119/diff/
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Marco Martin
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104119/">http://git.reviewboard.kde.org/r/104119/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think we need a better \
solution here</pre>  <br />

<p>- Martin</p>

<br />
<p>On February 29th, 2012, 5:23 p.m., Marco Martin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Marco Martin.</div>

<p style="color: grey;"><i>Updated Feb. 29, 2012, 5:23 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">in the windowstrip if partialreset is chacked, the window strip would \
correctly open a couple of times, then only the no windows entry would be present, \
probably due to windows appeared or gone away and the model getting incorrectly \
updated.

if the reset is always complete it works correctly, even tough is not really a good \
solution</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/tabbox/clientmodel.cpp <span style="color: grey">(4ca7fef)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104119/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 