[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: [KWin] Add keyboard shortcut to toggle between desktops (activities aware)
From: "makis marimpis" <makhsm () gmail ! com>
Date: 2012-05-02 12:07:48
Message-ID: 20120502120748.21359.8704 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On May 1, 2012, 6:02 p.m., Martin Gräßlin wrote:
> > kwin/kwinbindings.cpp, line 173
> > <http://git.reviewboard.kde.org/r/104649/diff/10/?file=61784#file61784line173>
> >
> > do we really need that shortcut? I don't see any advantage over the walk through \
> > desktop, which basically implements the same functionality as long as you just \
> > press it without holding the modifier.
>
> makis marimpis wrote:
> it is faster than iterating through desktops or invoking different shortcuts for \
> specific desktops
> Martin Gräßlin wrote:
> no there is a "toggle" mode. Give a try to "Walk Through Desktops" and not to "Walk \
> Through Desktop List".
yup, that is exactly what i wanted, i guess i ll drop the new feature and focus on \
the rest of the code. cool.
- makis
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104649/#review13234
-----------------------------------------------------------
On May 1, 2012, 6:47 p.m., makis marimpis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104649/
> -----------------------------------------------------------
>
> (Updated May 1, 2012, 6:47 p.m.)
>
>
> Review request for kwin.
>
>
> Description
> -------
>
> This patch, adds a shortcut which allows the user to toggle between the current and \
> the previous desktop (taking into consideration the current activity).
> (i couldn't find a relative bug report - it's just emerged from my daily needs)
>
>
> Diffs
> -----
>
> kwin/kwinbindings.cpp 3284cf07000744f83208b6ba467fb5427ffc846c
> kwin/useractions.cpp 09e18c3d061f6521749ebfe2665e2db9099dad9f
> kwin/workspace.h 9df435cebba26bea107bbb0ef8859863abe0fb73
> kwin/workspace.cpp b5c801403d1b77cf8054a51b39271ab0de4c0efb
>
> Diff: http://git.reviewboard.kde.org/r/104649/diff/
>
>
> Testing
> -------
>
> Switched desktops, started/stopped activities, toggled around, etc :D
>
>
> Thanks,
>
> makis marimpis
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104649/">http://git.reviewboard.kde.org/r/104649/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On May 1st, 2012, 6:02 p.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/104649/diff/10/?file=61784#file61784line173" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/kwinbindings.cpp</a> <span style="font-weight: normal;">
(Diff revision 10)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">DEF(I18N_NOOP("Switch to Next Desktop"), 0, \
slotSwitchDesktopNext());</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">173</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="n">DEF</span><span class="p">(</span><span class="n">I18N_NOOP</span><span \
class="p">(</span><span class="s">"Toggle Between Desktops"</span><span \
class="p">),</span> <span class="mi">0</span><span class="p">,</span> <span \
class="n">slotToggleBetweenDesktops</span><span class="p">());</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">do we really need that \
shortcut? I don't see any advantage over the walk through desktop, which \
basically implements the same functionality as long as you just press it without \
holding the modifier.</pre> </blockquote>
<p>On May 1st, 2012, 6:31 p.m., <b>makis marimpis</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">it is faster than \
iterating through desktops or invoking different shortcuts for specific \
desktops</pre> </blockquote>
<p>On May 1st, 2012, 6:58 p.m., <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">no there is a \
"toggle" mode. Give a try to "Walk Through Desktops" and not to \
"Walk Through Desktop List".</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yup, that \
is exactly what i wanted, i guess i ll drop the new feature and focus on the rest of \
the code. cool.</pre> <br />
<p>- makis</p>
<br />
<p>On May 1st, 2012, 6:47 p.m., makis marimpis wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By makis marimpis.</div>
<p style="color: grey;"><i>Updated May 1, 2012, 6:47 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch, adds a shortcut which allows the user to toggle between the \
current and the previous desktop (taking into consideration the current activity).
(i couldn't find a relative bug report - it's just emerged from my daily \
needs)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Switched desktops, started/stopped activities, toggled around, etc \
:D</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/kwinbindings.cpp <span style="color: \
grey">(3284cf07000744f83208b6ba467fb5427ffc846c)</span></li>
<li>kwin/useractions.cpp <span style="color: \
grey">(09e18c3d061f6521749ebfe2665e2db9099dad9f)</span></li>
<li>kwin/workspace.h <span style="color: \
grey">(9df435cebba26bea107bbb0ef8859863abe0fb73)</span></li>
<li>kwin/workspace.cpp <span style="color: \
grey">(b5c801403d1b77cf8054a51b39271ab0de4c0efb)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104649/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic