[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: "New Desktop" in To Desktop menu
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2012-05-01 18:04:40
Message-ID: 20120501180440.3945.2418 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104781/#review13235
-----------------------------------------------------------
kwin/useractions.cpp
<http://git.reviewboard.kde.org/r/104781/#comment10365>
looks like you forgot to use the getter
kwin/workspace.cpp
<http://git.reviewboard.kde.org/r/104781/#comment10361>
const not const_cast :-)
- Martin Gr=C3=A4=C3=9Flin
On May 1, 2012, 11:42 a.m., makis marimpis wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104781/
> -----------------------------------------------------------
> =
> (Updated May 1, 2012, 11:42 a.m.)
> =
> =
> Review request for kwin and Plasma.
> =
> =
> Description
> -------
> =
> I found http://community.kde.org/KWin/Ideas#.22New_Desktop.22_in_To_Deskt=
op_menu and i thought i would be nice to have.
> Only a few lines of code.
> =
> =
> Diffs
> -----
> =
> kwin/useractions.cpp 09e18c3d061f6521749ebfe2665e2db9099dad9f =
> kwin/workspace.h 9df435cebba26bea107bbb0ef8859863abe0fb73 =
> kwin/workspace.cpp b5c801403d1b77cf8054a51b39271ab0de4c0efb =
> libs/taskmanager/taskactions.cpp 7917c0d12511937e2ce0092720a82c1e99fcd6=
bd =
> libs/taskmanager/taskactions_p.h 52eae0513e62c7dbb3066fc26cd290bada7d14=
79 =
> =
> Diff: http://git.reviewboard.kde.org/r/104781/diff/
> =
> =
> Testing
> -------
> =
> Moved client to "New Desktop". Seems to work fine.
> =
> =
> Thanks,
> =
> makis marimpis
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104781/">http://git.reviewboard.kde.org/r/104781/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/104781/diff/3/?file=60670#file60670line504" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/useractions.cpp</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
Workspace::desktopPopupAboutToShow()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">504</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span \
class="n">numberOfDesktops</span><span class="p">()</span> <span \
class="o">>=</span> <span class="mi">20</span><span class="p">)</span> <span \
class="c1">//KWIN_MAX_NUMBER_DESKTOPS</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">looks like \
you forgot to use the getter</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/104781/diff/3/?file=60672#file60672line1425" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/workspace.cpp</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
Workspace::setCurrentDesktop(int new_desktop)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1425</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="kt">int</span> <span class="n">Workspace</span><span class="o">::</span><span \
class="n">maxNumberOfDesktops</span><span class="p">()</span> <span \
class="k">const_cast</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">const not \
const_cast :-)</pre> </div>
<br />
<p>- Martin</p>
<br />
<p>On May 1st, 2012, 11:42 a.m., makis marimpis wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Plasma.</div>
<div>By makis marimpis.</div>
<p style="color: grey;"><i>Updated May 1, 2012, 11:42 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I found \
http://community.kde.org/KWin/Ideas#.22New_Desktop.22_in_To_Desktop_menu and i \
thought i would be nice to have. Only a few lines of code.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Moved client to "New Desktop". Seems to work fine.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/useractions.cpp <span style="color: \
grey">(09e18c3d061f6521749ebfe2665e2db9099dad9f)</span></li>
<li>kwin/workspace.h <span style="color: \
grey">(9df435cebba26bea107bbb0ef8859863abe0fb73)</span></li>
<li>kwin/workspace.cpp <span style="color: \
grey">(b5c801403d1b77cf8054a51b39271ab0de4c0efb)</span></li>
<li>libs/taskmanager/taskactions.cpp <span style="color: \
grey">(7917c0d12511937e2ce0092720a82c1e99fcd6bd)</span></li>
<li>libs/taskmanager/taskactions_p.h <span style="color: \
grey">(52eae0513e62c7dbb3066fc26cd290bada7d1479)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104781/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic