[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Improved handling of defines in kwinbindings
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2012-04-30 21:27:35
Message-ID: 20120430212735.21676.95905 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On April 30, 2012, 8:48 p.m., Thomas Lübking wrote:
> > kwin/kwinbindings.cpp, line 30
> > <http://git.reviewboard.kde.org/r/104800/diff/1/?file=59736#file59736line30>
> >
> > I *really* wonder when this was "optional" in Qt - you're likely touching ancient \
> > code ... "IT BELONGS IN A MUSEUM!"
>
> Martin Gräßlin wrote:
> I found it: 34ac6f83c1ad191f687d21d3a2b9433da307d882 from Nov 16, 2001:
> Lots and lots and lots of changes all over the place for shortcut changes. \
> Including new KAccel and KGlobalAccel classes.
booooring ;-)
It's just an internal flag for an apparently static global accel implementation, cute \
but i had hoped for "experimental support for brand new signal/slot support in Qt \
1.02" :-(
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104800/#review13170
-----------------------------------------------------------
On April 30, 2012, 9:15 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104800/
> -----------------------------------------------------------
>
> (Updated April 30, 2012, 9:15 p.m.)
>
>
> Review request for kwin.
>
>
> Description
> -------
>
> Improved handling of defines in kwinbindings
>
> * drop NOSLOTS nowhere else used or set
> * drop DEF4 as unused
> * undef DEF3
> * drop KWIN_CONNECT (merged into DEF2 and DEF3)
>
> REVIEW: 104800
>
>
> Diffs
> -----
>
> kwin/kwinbindings.cpp 1f0d7ceda0c38485e9698d8b2b2005e8d501e488
>
> Diff: http://git.reviewboard.kde.org/r/104800/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104800/">http://git.reviewboard.kde.org/r/104800/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 30th, 2012, 8:48 p.m., <b>Thomas \
Lübking</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/104800/diff/1/?file=59736#file59736line30" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/kwinbindings.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">along \
with this program. If not, see <http://www.gnu.org/licenses/>.</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">30</font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#ifndef \
NOSLOTS</span></pre></td> <th bgcolor="#ebb1ba" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th> \
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I *really* wonder when \
this was "optional" in Qt - you're likely touching ancient code ... \
"IT BELONGS IN A MUSEUM!"</pre> </blockquote>
<p>On April 30th, 2012, 9:09 p.m., <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I found it: \
34ac6f83c1ad191f687d21d3a2b9433da307d882 from Nov 16, 2001: Lots and lots and lots of \
changes all over the place for shortcut changes. Including new KAccel and \
KGlobalAccel classes.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">booooring \
;-) It's just an internal flag for an apparently static global accel \
implementation, cute but i had hoped for "experimental support for brand new \
signal/slot support in Qt 1.02" :-(</pre> <br />
<p>- Thomas</p>
<br />
<p>On April 30th, 2012, 9:15 p.m., Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated April 30, 2012, 9:15 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Improved handling of defines in kwinbindings
* drop NOSLOTS nowhere else used or set
* drop DEF4 as unused
* undef DEF3
* drop KWIN_CONNECT (merged into DEF2 and DEF3)
REVIEW: 104800</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/kwinbindings.cpp <span style="color: \
grey">(1f0d7ceda0c38485e9698d8b2b2005e8d501e488)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104800/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic