'Re: Review Request: Default Bindings for Switching between Windows of current Application.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Default Bindings for Switching between Windows of current Application.
From:       "Ghislain Mary" <gmary () lunacymaze ! org>
Date:       2012-04-30 13:29:29
Message-ID: 20120430132929.25190.26266 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104730/
-----------------------------------------------------------

(Updated April 30, 2012, 1:29 p.m.)

Review request for kwin.

Changes
-------

Alright. So here is the patch with the shortcut for the reverse switching o=
f current application windows fully working.

Description
-------

Implementation of one of the kwin ideas from the community wiki. See http:/=
/community.kde.org/KWin/Ideas#Default_Bindings_for_Switching_between_Window=
s_of_current_Application

I had to add a new TabBoxMode enum value but I am not sure it is the good w=
ay to go. Any better suggestion is welcome.
This patch uses the primary window switching config with the ClientApplicat=
ionsMode forced to AllWindowsCurrentApplication. Maybe it would be better t=
o add a new tab in the tabbox kcm to configure this particular switching mo=
de (with the Applications combobox disabled). What do you think?
There is also an issue with the key shortcut. The key above the tab key dep=
ends on the keyboard layout. Is there a way to handle the shortcut in a lay=
out independent way? Moreover the shorcut I predefined for the reverse swit=
ching is not working correctly. Should it be Qt::ALT + Qt::Key_AsciiTilde o=
r Qt::ALT + Qt::SHIFT + Qt::Key_QuoteLeft?

Diffs (updated)
-----

  kwin/effects/coverswitch/coverswitch.cpp 850f6da =

  kwin/effects/flipswitch/flipswitch.cpp 54f4a29 =

  kwin/kcmkwin/kwintabbox/main.cpp 945ad03 =

  kwin/libkwineffects/kwinglobals.h 4bf8153 =

  kwin/tabbox/tabbox.h 05a129a =

  kwin/tabbox/tabbox.cpp a9c5cda =

Diff: http://git.reviewboard.kde.org/r/104730/diff/

Testing
-------

Thanks,

Ghislain Mary

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104730/">http://git.reviewboard.kde.org/r/104730/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Ghislain Mary.</div>

<p style="color: grey;"><i>Updated April 30, 2012, 1:29 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Alright. So here is the patch with the shortcut for the reverse \
switching of current application windows fully working.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Implementation of one of the kwin ideas from the community wiki. See \
http://community.kde.org/KWin/Ideas#Default_Bindings_for_Switching_between_Windows_of_current_Application

I had to add a new TabBoxMode enum value but I am not sure it is the good way to go. \
Any better suggestion is welcome. This patch uses the primary window switching config \
with the ClientApplicationsMode forced to AllWindowsCurrentApplication. Maybe it \
would be better to add a new tab in the tabbox kcm to configure this particular \
switching mode (with the Applications combobox disabled). What do you think? There is \
also an issue with the key shortcut. The key above the tab key depends on the \
keyboard layout. Is there a way to handle the shortcut in a layout independent way? \
Moreover the shorcut I predefined for the reverse switching is not working correctly. \
Should it be Qt::ALT + Qt::Key_AsciiTilde or Qt::ALT + Qt::SHIFT + \
Qt::Key_QuoteLeft?</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/effects/coverswitch/coverswitch.cpp <span style="color: \
grey">(850f6da)</span></li>

 <li>kwin/effects/flipswitch/flipswitch.cpp <span style="color: \
grey">(54f4a29)</span></li>

 <li>kwin/kcmkwin/kwintabbox/main.cpp <span style="color: grey">(945ad03)</span></li>

 <li>kwin/libkwineffects/kwinglobals.h <span style="color: \
grey">(4bf8153)</span></li>

 <li>kwin/tabbox/tabbox.h <span style="color: grey">(05a129a)</span></li>

 <li>kwin/tabbox/tabbox.cpp <span style="color: grey">(a9c5cda)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104730/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 