'Re: Review Request: Move KServiceTypeTrader query for Scripts into a thread'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Move KServiceTypeTrader query for Scripts into a thread
From:       "Commit Hook" <null () kde ! org>
Date:       2012-04-29 20:25:29
Message-ID: 20120429202529.13923.11149 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104768/#review13116
-----------------------------------------------------------

This review has been submitted with commit b043d091d6a01beacd3742ac0fe4ad5c=
a37a602a by Martin Gr=C3=A4=C3=9Flin to branch master.

- Commit Hook

On April 28, 2012, 11:38 a.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104768/
> -----------------------------------------------------------
> =

> (Updated April 28, 2012, 11:38 a.m.)
> =

> =

> Review request for kwin.
> =

> =

> Description
> -------
> =

> Move KServiceTypeTrader query for Scripts into a thread
> =

> Searching for the scripts to load is performed in an own
> thread including unloading of already loaded scripts which
> no longer should be loaded.
> =

> To ensure that two threads are not trying to load/unload
> at the same time a mutex is added to protect the list of
> loaded scripts.
> =

> REVIEW: 104768
> =

> =

> Diffs
> -----
> =

>   kwin/scripting/scripting.h 5fefe87d26883a6c2e1c44bdca7af72844ab82bb =

>   kwin/scripting/scripting.cpp 7e3e078c5756c24698d80b597cada84916a9fba3 =

> =

> Diff: http://git.reviewboard.kde.org/r/104768/diff/
> =

> =

> Testing
> -------
> =

> scripts still loaded.
> =

> =

> Thanks,
> =

> Martin Gr=C3=A4=C3=9Flin
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104768/">http://git.reviewboard.kde.org/r/104768/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit b043d091d6a01beacd3742ac0fe4ad5ca37a602a by Martin Gräßlin to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On April 28th, 2012, 11:38 a.m., Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated April 28, 2012, 11:38 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Move KServiceTypeTrader query for Scripts into a thread

Searching for the scripts to load is performed in an own
thread including unloading of already loaded scripts which
no longer should be loaded.

To ensure that two threads are not trying to load/unload
at the same time a mutex is added to protect the list of
loaded scripts.

REVIEW: 104768</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">scripts still loaded.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/scripting/scripting.h <span style="color: \
grey">(5fefe87d26883a6c2e1c44bdca7af72844ab82bb)</span></li>

 <li>kwin/scripting/scripting.cpp <span style="color: \
grey">(7e3e078c5756c24698d80b597cada84916a9fba3)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104768/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 