'Re: Review Request: Use KGlobal::config() instead of specifying kwinrc'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Use KGlobal::config() instead of specifying kwinrc
From:       "Commit Hook" <null () kde ! org>
Date:       2012-04-29 19:59:24
Message-ID: 20120429195924.11098.52918 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104754/#review13109
-----------------------------------------------------------

This review has been submitted with commit 236d4c81bc75768dbc8cf5e334cd78f8=
55e31b06 by Martin Gr=C3=A4=C3=9Flin to branch master.

- Commit Hook

On April 27, 2012, 9:44 a.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104754/
> -----------------------------------------------------------
> =

> (Updated April 27, 2012, 9:44 a.m.)
> =

> =

> Review request for kwin.
> =

> =

> Description
> -------
> =

> Use KGlobal::config() instead of specifying kwinrc
> =

> Inside KWin we can just use the global configuration
> instead of manually opening kwinrc which is just the
> same.
> =

> There is one remaining usage of kwinrc in main.cpp, but that is before th=
e KAboutData is specified.
> =

> Requires https://git.reviewboard.kde.org/r/104753/ and https://git.review=
board.kde.org/r/104752/ to go in first as those remove usage of Compositing=
Prefs from KCMs.
> =

> =

> Diffs
> -----
> =

>   kwin/composite.cpp 6a27e000beb5fccbea13c9268ab046da314c9fdb =

>   kwin/compositingprefs.cpp 4a7f9b89c7b4f92d8916879eeb6b92e3cba1fe10 =

>   kwin/libkwineffects/kwineffects.cpp 135c9ae16573942b6065da7da0cdcff9a84=
20695 =

>   kwin/libkwineffects/kwinglutils.cpp 3a7692f84eb16b4794859db8a2c8e41357b=
7c382 =

>   kwin/workspace.cpp 926d83be6310a2b27ade2d1c217eb26ddffcdeea =

> =

> Diff: http://git.reviewboard.kde.org/r/104754/diff/
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Martin Gr=C3=A4=C3=9Flin
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104754/">http://git.reviewboard.kde.org/r/104754/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 236d4c81bc75768dbc8cf5e334cd78f855e31b06 by Martin Gräßlin to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On April 27th, 2012, 9:44 a.m., Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated April 27, 2012, 9:44 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use KGlobal::config() instead of specifying kwinrc

Inside KWin we can just use the global configuration
instead of manually opening kwinrc which is just the
same.

There is one remaining usage of kwinrc in main.cpp, but that is before the KAboutData \
is specified.

Requires https://git.reviewboard.kde.org/r/104753/ and \
https://git.reviewboard.kde.org/r/104752/ to go in first as those remove usage of \
CompositingPrefs from KCMs.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/composite.cpp <span style="color: \
grey">(6a27e000beb5fccbea13c9268ab046da314c9fdb)</span></li>

 <li>kwin/compositingprefs.cpp <span style="color: \
grey">(4a7f9b89c7b4f92d8916879eeb6b92e3cba1fe10)</span></li>

 <li>kwin/libkwineffects/kwineffects.cpp <span style="color: \
grey">(135c9ae16573942b6065da7da0cdcff9a8420695)</span></li>

 <li>kwin/libkwineffects/kwinglutils.cpp <span style="color: \
grey">(3a7692f84eb16b4794859db8a2c8e41357b7c382)</span></li>

 <li>kwin/workspace.cpp <span style="color: \
grey">(926d83be6310a2b27ade2d1c217eb26ddffcdeea)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104754/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 