'Re: Review Request: Drop CompositingPrefs from Compositing KCM'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Drop CompositingPrefs from Compositing KCM
From:       "Commit Hook" <null () kde ! org>
Date:       2012-04-29 19:52:40
Message-ID: 20120429195240.10638.10217 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104753/#review13107
-----------------------------------------------------------

This review has been submitted with commit 234aaf9bbd8c2aa1f21d96e9aa0196b0=
3c1edea9 by Martin Gr=C3=A4=C3=9Flin to branch master.

- Commit Hook

On April 29, 2012, 6:44 a.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104753/
> -----------------------------------------------------------
> =

> (Updated April 29, 2012, 6:44 a.m.)
> =

> =

> Review request for kwin.
> =

> =

> Description
> -------
> =

> Drop CompositingPrefs from Compositing KCM
> =

> Instead of getting the information from CompositingPrefs
> the running KWin instance is queried through D-Bus.
> In general the running KWin should have more information
> about whether Compositing will work or not.
> =

> This means the kcm no longer has to link OpenGL.
> =

> =

> Diffs
> -----
> =

>   kwin/composite.cpp 2ee9e77 =

>   kwin/kcmkwin/kwincompositing/CMakeLists.txt decc6b7 =

>   kwin/kcmkwin/kwincompositing/main.h 8e2f3bb =

>   kwin/kcmkwin/kwincompositing/main.cpp a265136 =

>   kwin/org.kde.KWin.xml a0b3a29 =

>   kwin/workspace.h 2f1547f =

> =

> Diff: http://git.reviewboard.kde.org/r/104753/diff/
> =

> =

> Testing
> -------
> =

> =

> Screenshots
> -----------
> =

> Dialog if D-Bus interface is not valid
>   http://git.reviewboard.kde.org/r/104753/s/549/
> =

> =

> Thanks,
> =

> Martin Gr=C3=A4=C3=9Flin
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104753/">http://git.reviewboard.kde.org/r/104753/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 234aaf9bbd8c2aa1f21d96e9aa0196b03c1edea9 by Martin Gräßlin to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On April 29th, 2012, 6:44 a.m., Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated April 29, 2012, 6:44 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Drop CompositingPrefs from Compositing KCM

Instead of getting the information from CompositingPrefs
the running KWin instance is queried through D-Bus.
In general the running KWin should have more information
about whether Compositing will work or not.

This means the kcm no longer has to link OpenGL.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/composite.cpp <span style="color: grey">(2ee9e77)</span></li>

 <li>kwin/kcmkwin/kwincompositing/CMakeLists.txt <span style="color: \
grey">(decc6b7)</span></li>

 <li>kwin/kcmkwin/kwincompositing/main.h <span style="color: \
grey">(8e2f3bb)</span></li>

 <li>kwin/kcmkwin/kwincompositing/main.cpp <span style="color: \
grey">(a265136)</span></li>

 <li>kwin/org.kde.KWin.xml <span style="color: grey">(a0b3a29)</span></li>

 <li>kwin/workspace.h <span style="color: grey">(2f1547f)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104753/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>

<div>

 <a href="http://git.reviewboard.kde.org/r/104753/s/549/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/04/27/kcm-error-message_400x100.png" \
style="border: 1px black solid;" alt="Dialog if D-Bus interface is not valid" /></a>

</div>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 