[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Remove GL context creation from CompositingPrefs
From: "Commit Hook" <null () kde ! org>
Date: 2012-04-29 19:48:27
Message-ID: 20120429194827.10372.7978 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104778/#review13104
-----------------------------------------------------------
This review has been submitted with commit ef999125beff219befa8e09cdbfbd702=
88b20e99 by Martin Gr=C3=A4=C3=9Flin to branch master.
- Commit Hook
On April 29, 2012, 6:29 a.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104778/
> -----------------------------------------------------------
> =
> (Updated April 29, 2012, 6:29 a.m.)
> =
> =
> Review request for kwin.
> =
> =
> Description
> -------
> =
> Remove GL context creation from CompositingPrefs
> =
> Whether creating the OpenGL context succeeds or not
> had no influence in any decisions on the used settings
> for OpenGL based compositing.
> =
> The only valid information CompositingPrefs still detects
> is whether direct rendering should be used which is
> performed out of process and does not require a context.
> =
> So overall the context creation is not needed and can
> be removed.
> =
> Move detection of GLPlatform and printResults into Scene
> =
> This means the GLPlatform is filled with values from the
> context actually used for Compositing and if XRender
> compositing is used no OpenGL information is logged.
> =
> Make GLVSync a complete user controlled variable
> =
> There is no need to have it driver specific any more.
> All drivers seem to support it (only Intel had been
> opt-ed out without any apparent reason shown in commit log).
> =
> This was the last driver specific setting which means that
> the method applyDriverSpecificSettings() got dropped from
> CompositingPrefs.
> =
> Drop recommendCompositing from CompositingPrefs
> =
> It's always true which means it's no longer needed.
> =
> Remove strict binding from compositing prefs
> =
> Strict binding follows the driver (GLPlattform) unless
> the user has a config value specified in the kwinrc.
> =
> For this a new property is added to Options to indicate
> whether strict binding is user defined or follows the
> driver. In case of driver the strict binding option is
> set when OpenGL compositor starts up.
> =
> =
> Diffs
> -----
> =
> kwin/compositingprefs.h 50c036406b92e7f23cef21e8ef06b26fe805a8a4 =
> kwin/compositingprefs.cpp 4a7f9b89c7b4f92d8916879eeb6b92e3cba1fe10 =
> kwin/kcmkwin/kwincompositing/main.cpp a2651368ac4527758cc4074a019ac672f=
51b0672 =
> kwin/options.h cd4282f380e20524718dd5b739b32dcc8db613b6 =
> kwin/options.cpp 7bb35d0dad106e21f2e6bae00e946d6b5e688a2a =
> kwin/scene_opengl_egl.cpp d0ce3608c48a4795dc509fe6313d22c9f92c9ae0 =
> kwin/scene_opengl_glx.cpp 67400a8e5ee51393a326798395580f70f9eaadb3 =
> =
> Diff: http://git.reviewboard.kde.org/r/104778/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Martin Gr=C3=A4=C3=9Flin
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104778/">http://git.reviewboard.kde.org/r/104778/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit ef999125beff219befa8e09cdbfbd70288b20e99 by Martin Gräßlin to \
branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On April 29th, 2012, 6:29 a.m., Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated April 29, 2012, 6:29 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Remove GL context creation from CompositingPrefs
Whether creating the OpenGL context succeeds or not
had no influence in any decisions on the used settings
for OpenGL based compositing.
The only valid information CompositingPrefs still detects
is whether direct rendering should be used which is
performed out of process and does not require a context.
So overall the context creation is not needed and can
be removed.
Move detection of GLPlatform and printResults into Scene
This means the GLPlatform is filled with values from the
context actually used for Compositing and if XRender
compositing is used no OpenGL information is logged.
Make GLVSync a complete user controlled variable
There is no need to have it driver specific any more.
All drivers seem to support it (only Intel had been
opt-ed out without any apparent reason shown in commit log).
This was the last driver specific setting which means that
the method applyDriverSpecificSettings() got dropped from
CompositingPrefs.
Drop recommendCompositing from CompositingPrefs
It's always true which means it's no longer needed.
Remove strict binding from compositing prefs
Strict binding follows the driver (GLPlattform) unless
the user has a config value specified in the kwinrc.
For this a new property is added to Options to indicate
whether strict binding is user defined or follows the
driver. In case of driver the strict binding option is
set when OpenGL compositor starts up.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/compositingprefs.h <span style="color: \
grey">(50c036406b92e7f23cef21e8ef06b26fe805a8a4)</span></li>
<li>kwin/compositingprefs.cpp <span style="color: \
grey">(4a7f9b89c7b4f92d8916879eeb6b92e3cba1fe10)</span></li>
<li>kwin/kcmkwin/kwincompositing/main.cpp <span style="color: \
grey">(a2651368ac4527758cc4074a019ac672f51b0672)</span></li>
<li>kwin/options.h <span style="color: \
grey">(cd4282f380e20524718dd5b739b32dcc8db613b6)</span></li>
<li>kwin/options.cpp <span style="color: \
grey">(7bb35d0dad106e21f2e6bae00e946d6b5e688a2a)</span></li>
<li>kwin/scene_opengl_egl.cpp <span style="color: \
grey">(d0ce3608c48a4795dc509fe6313d22c9f92c9ae0)</span></li>
<li>kwin/scene_opengl_glx.cpp <span style="color: \
grey">(67400a8e5ee51393a326798395580f70f9eaadb3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104778/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic