[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: "New Desktop" in To Desktop menu
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2012-04-29 16:47:56
Message-ID: 20120429164756.21286.33741 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On April 29, 2012, 4:21 p.m., Ghislain Mary wrote:
> > Maybe it would be good to also add an action to send the client to a ne=
w desktop if there is currently only one desktop (ie if the client desktop =
popup menu is not shown).
it's questionable. The menu is not shown at all if the user does not use de=
sktops. So she does not know that there are multiple desktops and the menu =
would be quite confusing to her. I think it's better to leave it that way, =
but hope to remember this when I meet an usability expert the next time :-)
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104781/#review13075
-----------------------------------------------------------
On April 29, 2012, 3:37 p.m., makis marimpis wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104781/
> -----------------------------------------------------------
> =
> (Updated April 29, 2012, 3:37 p.m.)
> =
> =
> Review request for kwin.
> =
> =
> Description
> -------
> =
> I found http://community.kde.org/KWin/Ideas#.22New_Desktop.22_in_To_Deskt=
op_menu and i thought i would be nice to have.
> Only a few lines of code.
> =
> =
> Diffs
> -----
> =
> kwin/useractions.cpp 09e18c3d061f6521749ebfe2665e2db9099dad9f =
> =
> Diff: http://git.reviewboard.kde.org/r/104781/diff/
> =
> =
> Testing
> -------
> =
> Moved client to "New Desktop". Seems to work fine.
> =
> =
> Thanks,
> =
> makis marimpis
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104781/">http://git.reviewboard.kde.org/r/104781/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 29th, 2012, 4:21 p.m., <b>Ghislain \
Mary</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Maybe it would be good to also add an action to send the client to a new \
desktop if there is currently only one desktop (ie if the client desktop popup menu \
is not shown).</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">it's questionable. \
The menu is not shown at all if the user does not use desktops. So she does not know \
that there are multiple desktops and the menu would be quite confusing to her. I \
think it's better to leave it that way, but hope to remember this when I meet an \
usability expert the next time :-)</pre> <br />
<p>- Martin</p>
<br />
<p>On April 29th, 2012, 3:37 p.m., makis marimpis wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By makis marimpis.</div>
<p style="color: grey;"><i>Updated April 29, 2012, 3:37 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I found \
http://community.kde.org/KWin/Ideas#.22New_Desktop.22_in_To_Desktop_menu and i \
thought i would be nice to have. Only a few lines of code.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Moved client to "New Desktop". Seems to work fine.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/useractions.cpp <span style="color: \
grey">(09e18c3d061f6521749ebfe2665e2db9099dad9f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104781/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic