[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: [KWin] Add keyboard shortcut to toggle between desktops (activities aware)
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2012-04-28 20:26:06
Message-ID: 20120428202606.5875.26418 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104649/#review13038
-----------------------------------------------------------
a) the latest patch applies to your former patch, not some vanilla kwin code
b) the patch will never make it to 4.8
- because it introduces a new feature
- because it's pretty late in the 4.8 cycle anyway
-> focus on get it done for git master
- Thomas L=C3=BCbking
On April 28, 2012, 8:13 p.m., makis marimpis wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104649/
> -----------------------------------------------------------
> =
> (Updated April 28, 2012, 8:13 p.m.)
> =
> =
> Review request for kwin.
> =
> =
> Description
> -------
> =
> This patch, adds a shortcut which allows the user to toggle between the c=
urrent and the previous desktop (taking into consideration the current acti=
vity).
> =
> (i couldn't find a relative bug report - it's just emerged from my daily =
needs)
> =
> =
> Diffs
> -----
> =
> kwin/useractions.cpp 7614c726087d1563f5822ddfcd35728637d97eae =
> kwin/workspace.h d5942dca380fa3b22616b7ec12fa394869bb187d =
> kwin/workspace.cpp b4fd27746da2e77af36ff6f24c261ed1f76206fa =
> =
> Diff: http://git.reviewboard.kde.org/r/104649/diff/
> =
> =
> Testing
> -------
> =
> Switched desktops, started/stopped activities, toggled around, etc :D
> =
> =
> Thanks,
> =
> makis marimpis
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104649/">http://git.reviewboard.kde.org/r/104649/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">a) the latest patch \
applies to your former patch, not some vanilla kwin code b) the patch will never make \
it to 4.8
- because it introduces a new feature
- because it's pretty late in the 4.8 cycle anyway
-> focus on get it done for git master</pre>
<br />
<p>- Thomas</p>
<br />
<p>On April 28th, 2012, 8:13 p.m., makis marimpis wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By makis marimpis.</div>
<p style="color: grey;"><i>Updated April 28, 2012, 8:13 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch, adds a shortcut which allows the user to toggle between the \
current and the previous desktop (taking into consideration the current activity).
(i couldn't find a relative bug report - it's just emerged from my daily \
needs)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Switched desktops, started/stopped activities, toggled around, etc \
:D</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/useractions.cpp <span style="color: \
grey">(7614c726087d1563f5822ddfcd35728637d97eae)</span></li>
<li>kwin/workspace.h <span style="color: \
grey">(d5942dca380fa3b22616b7ec12fa394869bb187d)</span></li>
<li>kwin/workspace.cpp <span style="color: \
grey">(b4fd27746da2e77af36ff6f24c261ed1f76206fa)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104649/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic