'Re: Review Request: Only create decoration once during Client::manage'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Only create decoration once during Client::manage
From:       Thomas_Lübking <thomas.luebking () web ! de>
Date:       2012-04-28 13:04:12
Message-ID: 20120428130412.29642.81823 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104758/#review13024
-----------------------------------------------------------

"Ship it" from my side - no walking windows.

But maybe add/call Philipp because https://git.reviewboard.kde.org/r/101370=
/ introduced the extra updateDecoration and i'm not sure why. (also in ::fi=
nishCompositing())

- Thomas L=C3=BCbking

On April 28, 2012, 9:05 a.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104758/
> -----------------------------------------------------------
> =

> (Updated April 28, 2012, 9:05 a.m.)
> =

> =

> Review request for kwin.
> =

> =

> Description
> -------
> =

> Client::manage calls setupCompositing on the not
> yet fully managed client before it wants to create
> the window decoration. This means the decoration is
> created twice and maybe even if not needed (noBorder
> not yet set).
> =

> If the Client is not yet managed setupCompositing
> will not update the decoration - it will be handled
> by manage later on.
> =

> Furthermore if compositing is not active, setup
> compositing does not have to perform any action.
> =

> =

> Diffs
> -----
> =

>   kwin/composite.cpp 2ee9e77 =

> =

> Diff: http://git.reviewboard.kde.org/r/104758/diff/
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Martin Gr=C3=A4=C3=9Flin
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104758/">http://git.reviewboard.kde.org/r/104758/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">&quot;Ship it&quot; from \
my side - no walking windows.

But maybe add/call Philipp because https://git.reviewboard.kde.org/r/101370/ \
introduced the extra updateDecoration and i&#39;m not sure why. (also in \
::finishCompositing())</pre>  <br />

<p>- Thomas</p>

<br />
<p>On April 28th, 2012, 9:05 a.m., Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated April 28, 2012, 9:05 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Client::manage calls setupCompositing on the not yet fully managed \
client before it wants to create the window decoration. This means the decoration is
created twice and maybe even if not needed (noBorder
not yet set).

If the Client is not yet managed setupCompositing
will not update the decoration - it will be handled
by manage later on.

Furthermore if compositing is not active, setup
compositing does not have to perform any action.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/composite.cpp <span style="color: grey">(2ee9e77)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104758/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 