'Re: Review Request: Do not perform setupCompositing on Client if Toplevel is not setup'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Do not perform setupCompositing on Client if Toplevel is not setup
From:       "Commit Hook" <null () kde ! org>
Date:       2012-04-28 8:59:37
Message-ID: 20120428085937.31577.93176 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104767/#review13018
-----------------------------------------------------------

This review has been submitted with commit 0bcf333d9d36e422a7fc17bb7cafae8b=
0c5f6620 by Martin Gr=C3=A4=C3=9Flin to branch master.

- Commit Hook

On April 28, 2012, 7:42 a.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104767/
> -----------------------------------------------------------
> =

> (Updated April 28, 2012, 7:42 a.m.)
> =

> =

> Review request for kwin.
> =

> =

> Description
> -------
> =

> Do not perform setupCompositing on Client if Toplevel is not setup
> =

> Toplevel::setupCompositing returns a boolean value and returns
> false in the cases where it has not setup compositing.
> =

> This is used by the specialization on Client to not perform the
> Client specific setup if Toplevel has not setup.
> =

> =

> Diffs
> -----
> =

>   kwin/client.h c34079baa9d6232e3b23acafc52eb83615f003f4 =

>   kwin/composite.cpp 6a27e000beb5fccbea13c9268ab046da314c9fdb =

>   kwin/toplevel.h 95044f3e632e6d6d56ca55faa6d6dfccacda0bdf =

> =

> Diff: http://git.reviewboard.kde.org/r/104767/diff/
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Martin Gr=C3=A4=C3=9Flin
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104767/">http://git.reviewboard.kde.org/r/104767/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 0bcf333d9d36e422a7fc17bb7cafae8b0c5f6620 by Martin Gräßlin to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On April 28th, 2012, 7:42 a.m., Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated April 28, 2012, 7:42 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Do not perform setupCompositing on Client if Toplevel is not setup

Toplevel::setupCompositing returns a boolean value and returns
false in the cases where it has not setup compositing.

This is used by the specialization on Client to not perform the
Client specific setup if Toplevel has not setup.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/client.h <span style="color: \
grey">(c34079baa9d6232e3b23acafc52eb83615f003f4)</span></li>

 <li>kwin/composite.cpp <span style="color: \
grey">(6a27e000beb5fccbea13c9268ab046da314c9fdb)</span></li>

 <li>kwin/toplevel.h <span style="color: \
grey">(95044f3e632e6d6d56ca55faa6d6dfccacda0bdf)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104767/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 