[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Add appmenu support to kwin
From: "Lamarque Vieira Souza" <lamarque () kde ! org>
Date: 2012-04-27 19:01:58
Message-ID: 20120427190158.5801.24279 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104344/#review13002
-----------------------------------------------------------
appmenu/lib/com.canonical.AppMenu.Registrar.xml
<http://git.reviewboard.kde.org/r/104344/#comment10118>
Curious that Canonical is using a Spanish (also Portuguese word) for this :-)
appmenu/lib/importer_interface.h
<http://git.reviewboard.kde.org/r/104344/#comment10117>
QDBusReply and waitForFinished are no go from my part. Please use them only when \
really really necessary.
- Lamarque Vieira Souza
On April 16, 2012, 1:55 p.m., Bellegarde Cédric wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104344/
> -----------------------------------------------------------
>
> (Updated April 16, 2012, 1:55 p.m.)
>
>
> Review request for kwin.
>
>
> Description
> -------
>
> Here a patch to add appmenu support to kwin:
> - via a menu button in titlebar
> - via a global shortcut
>
> Works by Lionel Chauvin and me, original review request: \
> https://git.reviewboard.kde.org/r/101162/
> It depends on:
> http://quickgit.kde.org/index.php?p=kded-appmenu.git
>
> Kubuntu and ArchLinux packages (KDE 4.8.1 backport) availables here:
> http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
>
> It looks like this:
> http://www.youtube.com/watch?v=j0o1sRLRc60&hd=1
>
> I remove ( http://kde-look.org/CONTENT/content-pre1/141254-1.png ) this way to show \
> menu button because:
> - It conflicts with window menu button
> - Using application name is impossible (we only have window class and sometime it's \
> quite ugly)
> - Using just "Menu" really looks bad
>
>
> Diffs
> -----
>
> CMakeLists.txt 1385cb6
> appmenu/CMakeLists.txt PRE-CREATION
> appmenu/lib/CMakeLists.txt PRE-CREATION
> appmenu/lib/com.canonical.AppMenu.Registrar.xml PRE-CREATION
> appmenu/lib/importer_interface.h PRE-CREATION
> appmenu/lib/importer_interface.cpp PRE-CREATION
> appmenu/lib/kappmenu_export.h PRE-CREATION
> appmenu/lib/kappmenuimporter.h PRE-CREATION
> appmenu/lib/kappmenuimporter.cpp PRE-CREATION
> appmenu/lib/menuinfo.h PRE-CREATION
> appmenu/module/CMakeLists.txt PRE-CREATION
> appmenu/module/appmenu.h PRE-CREATION
> appmenu/module/appmenu.cpp PRE-CREATION
> appmenu/module/appmenu.desktop PRE-CREATION
> appmenu/module/com.canonical.AppMenu.Registrar.xml PRE-CREATION
> appmenu/module/registrar.h PRE-CREATION
> appmenu/module/registrar.cpp PRE-CREATION
> kwin/CMakeLists.txt 6e29be2
> kwin/bridge.h 64108e5
> kwin/bridge.cpp 897d432
> kwin/client.h 2f55087
> kwin/client.cpp 410ff43
> kwin/clients/oxygen/oxygenbutton.h ea11717
> kwin/clients/oxygen/oxygenbutton.cpp 28aa8b1
> kwin/clients/oxygen/oxygenclient.h e1d1d0a
> kwin/clients/oxygen/oxygenclient.cpp 7a2b021
> kwin/clients/oxygen/oxygenfactory.h b38b097
> kwin/clients/oxygen/oxygenfactory.cpp 827aa59
> kwin/config-kwin.h.cmake 49b643a
> kwin/kcmkwin/kwindecoration/CMakeLists.txt 4762bb9
> kwin/kcmkwin/kwindecoration/buttons.cpp 2d12244
> kwin/kcmkwin/kwindecoration/preview.h 20ee869
> kwin/kcmkwin/kwindecoration/preview.cpp fe802c7
> kwin/kcmkwin/kwinoptions/windows.h 3fadf2c
> kwin/kcmkwin/kwinoptions/windows.cpp a7c0f4f
> kwin/kwin.kcfg cf6537e
> kwin/kwinbindings.cpp 3284cf0
> kwin/libkdecorations/kcommondecoration.h 3fe9fcf
> kwin/libkdecorations/kcommondecoration.cpp 13a4c49
> kwin/libkdecorations/kdecoration.h 442d0a1
> kwin/libkdecorations/kdecoration.cpp 71f4f8d
> kwin/libkdecorations/kdecorationbridge.h b7d0619
> kwin/menubar.h PRE-CREATION
> kwin/menubar.cpp PRE-CREATION
> kwin/options.h 855ed78
> kwin/options.cpp a250e79
> kwin/scripting/workspace_wrapper.h 76d60bf
> kwin/scripting/workspace_wrapper.cpp c5b684a
> kwin/useractions.cpp 09e18c3
> kwin/workspace.h 9df435c
> kwin/workspace.cpp b5c8014
>
> Diff: http://git.reviewboard.kde.org/r/104344/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bellegarde Cédric
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104344/">http://git.reviewboard.kde.org/r/104344/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/104344/diff/9/?file=56727#file56727line7" \
style="color: black; font-weight: bold; text-decoration: \
underline;">appmenu/lib/com.canonical.AppMenu.Registrar.xml</a> <span \
style="font-weight: normal;">
(Diff revision 9)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">7</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cp"><span class="tb"> </span> main interface is docuemented here: @ref \
com::canonical::AppMenu::Registrar.</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Curious \
that Canonical is using a Spanish (also Portuguese word) for this :-)</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/104344/diff/9/?file=56728#file56728line46" \
style="color: black; font-weight: bold; text-decoration: \
underline;">appmenu/lib/importer_interface.h</a> <span style="font-weight: normal;">
(Diff revision 9)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">public Q_SLOTS: // METHODS</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">46</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="kr">inline</span> <span class="n">QDBusReply</span><span \
class="o"><</span><span class="n">QString</span><span class="o">></span> <span \
class="n">GetMenuForWindow</span><span class="p">(</span><span class="n">uint</span> \
<span class="n">windowId</span><span class="p">,</span> <span \
class="n">QDBusObjectPath</span> <span class="o">&</span><span \
class="n">menuObjectPath</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">QDBusReply \
and waitForFinished are no go from my part. Please use them only when really really \
necessary.</pre> </div>
<br />
<p>- Lamarque Vieira</p>
<br />
<p>On April 16th, 2012, 1:55 p.m., Bellegarde Cédric wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Bellegarde Cédric.</div>
<p style="color: grey;"><i>Updated April 16, 2012, 1:55 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Here a patch to add appmenu support to kwin:
- via a menu button in titlebar
- via a global shortcut
Works by Lionel Chauvin and me, original review request: \
https://git.reviewboard.kde.org/r/101162/
It depends on:
http://quickgit.kde.org/index.php?p=kded-appmenu.git
Kubuntu and ArchLinux packages (KDE 4.8.1 backport) availables here:
http://kde-look.org/content/show.php/kde-workspace-appmenu?content=148583
It looks like this:
http://www.youtube.com/watch?v=j0o1sRLRc60&hd=1
I remove ( http://kde-look.org/CONTENT/content-pre1/141254-1.png ) this way to show \
menu button because:
- It conflicts with window menu button
- Using application name is impossible (we only have window class and sometime \
it's quite ugly)
- Using just "Menu" really looks bad</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(1385cb6)</span></li>
<li>appmenu/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>appmenu/lib/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>appmenu/lib/com.canonical.AppMenu.Registrar.xml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>appmenu/lib/importer_interface.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>appmenu/lib/importer_interface.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>appmenu/lib/kappmenu_export.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>appmenu/lib/kappmenuimporter.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>appmenu/lib/kappmenuimporter.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>appmenu/lib/menuinfo.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>appmenu/module/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>appmenu/module/appmenu.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>appmenu/module/appmenu.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>appmenu/module/appmenu.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>appmenu/module/com.canonical.AppMenu.Registrar.xml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>appmenu/module/registrar.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>appmenu/module/registrar.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/CMakeLists.txt <span style="color: grey">(6e29be2)</span></li>
<li>kwin/bridge.h <span style="color: grey">(64108e5)</span></li>
<li>kwin/bridge.cpp <span style="color: grey">(897d432)</span></li>
<li>kwin/client.h <span style="color: grey">(2f55087)</span></li>
<li>kwin/client.cpp <span style="color: grey">(410ff43)</span></li>
<li>kwin/clients/oxygen/oxygenbutton.h <span style="color: \
grey">(ea11717)</span></li>
<li>kwin/clients/oxygen/oxygenbutton.cpp <span style="color: \
grey">(28aa8b1)</span></li>
<li>kwin/clients/oxygen/oxygenclient.h <span style="color: \
grey">(e1d1d0a)</span></li>
<li>kwin/clients/oxygen/oxygenclient.cpp <span style="color: \
grey">(7a2b021)</span></li>
<li>kwin/clients/oxygen/oxygenfactory.h <span style="color: \
grey">(b38b097)</span></li>
<li>kwin/clients/oxygen/oxygenfactory.cpp <span style="color: \
grey">(827aa59)</span></li>
<li>kwin/config-kwin.h.cmake <span style="color: grey">(49b643a)</span></li>
<li>kwin/kcmkwin/kwindecoration/CMakeLists.txt <span style="color: \
grey">(4762bb9)</span></li>
<li>kwin/kcmkwin/kwindecoration/buttons.cpp <span style="color: \
grey">(2d12244)</span></li>
<li>kwin/kcmkwin/kwindecoration/preview.h <span style="color: \
grey">(20ee869)</span></li>
<li>kwin/kcmkwin/kwindecoration/preview.cpp <span style="color: \
grey">(fe802c7)</span></li>
<li>kwin/kcmkwin/kwinoptions/windows.h <span style="color: \
grey">(3fadf2c)</span></li>
<li>kwin/kcmkwin/kwinoptions/windows.cpp <span style="color: \
grey">(a7c0f4f)</span></li>
<li>kwin/kwin.kcfg <span style="color: grey">(cf6537e)</span></li>
<li>kwin/kwinbindings.cpp <span style="color: grey">(3284cf0)</span></li>
<li>kwin/libkdecorations/kcommondecoration.h <span style="color: \
grey">(3fe9fcf)</span></li>
<li>kwin/libkdecorations/kcommondecoration.cpp <span style="color: \
grey">(13a4c49)</span></li>
<li>kwin/libkdecorations/kdecoration.h <span style="color: \
grey">(442d0a1)</span></li>
<li>kwin/libkdecorations/kdecoration.cpp <span style="color: \
grey">(71f4f8d)</span></li>
<li>kwin/libkdecorations/kdecorationbridge.h <span style="color: \
grey">(b7d0619)</span></li>
<li>kwin/menubar.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kwin/menubar.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kwin/options.h <span style="color: grey">(855ed78)</span></li>
<li>kwin/options.cpp <span style="color: grey">(a250e79)</span></li>
<li>kwin/scripting/workspace_wrapper.h <span style="color: \
grey">(76d60bf)</span></li>
<li>kwin/scripting/workspace_wrapper.cpp <span style="color: \
grey">(c5b684a)</span></li>
<li>kwin/useractions.cpp <span style="color: grey">(09e18c3)</span></li>
<li>kwin/workspace.h <span style="color: grey">(9df435c)</span></li>
<li>kwin/workspace.cpp <span style="color: grey">(b5c8014)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104344/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic