'Re: Review Request: Drop CompositingPrefs detection from screenedges kcm'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Drop CompositingPrefs detection from screenedges kcm
From:       "Commit Hook" <null () kde ! org>
Date:       2012-04-27 14:42:56
Message-ID: 20120427144256.3192.53055 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104752/#review12988
-----------------------------------------------------------

This review has been submitted with commit 3096f5e0996f774bfa659b4184438fa5=
8be9a195 by Martin Gr=C3=A4=C3=9Flin to branch master.

- Commit Hook

On April 27, 2012, 7:31 a.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104752/
> -----------------------------------------------------------
> =

> (Updated April 27, 2012, 7:31 a.m.)
> =

> =

> Review request for kwin.
> =

> =

> Description
> -------
> =

> Drop CompositingPrefs detection from screenedges kcm
> =

> CompositingPrefs have only be used to get the default
> value when reading whether the Compositing Enabled
> config option.
> =

> But CompositingPrefs always returns true which makes
> it useless to create an OpenGL context for this.
> =

> =

> Diffs
> -----
> =

>   kwin/kcmkwin/kwinscreenedges/CMakeLists.txt cecff7c4aad90f2395ba61185a9=
5148c7b36e079 =

>   kwin/kcmkwin/kwinscreenedges/main.h c69b213df6d5908d3e0ac0cf2501d1a6a03=
43007 =

>   kwin/kcmkwin/kwinscreenedges/main.cpp 9f56b362f084b6bb8f91e58f3cb44f52f=
90b349e =

> =

> Diff: http://git.reviewboard.kde.org/r/104752/diff/
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Martin Gr=C3=A4=C3=9Flin
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104752/">http://git.reviewboard.kde.org/r/104752/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 3096f5e0996f774bfa659b4184438fa58be9a195 by Martin Gräßlin to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On April 27th, 2012, 7:31 a.m., Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated April 27, 2012, 7:31 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Drop CompositingPrefs detection from screenedges kcm

CompositingPrefs have only be used to get the default
value when reading whether the Compositing Enabled
config option.

But CompositingPrefs always returns true which makes
it useless to create an OpenGL context for this.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/kcmkwin/kwinscreenedges/CMakeLists.txt <span style="color: \
grey">(cecff7c4aad90f2395ba61185a95148c7b36e079)</span></li>

 <li>kwin/kcmkwin/kwinscreenedges/main.h <span style="color: \
grey">(c69b213df6d5908d3e0ac0cf2501d1a6a0343007)</span></li>

 <li>kwin/kcmkwin/kwinscreenedges/main.cpp <span style="color: \
grey">(9f56b362f084b6bb8f91e58f3cb44f52f90b349e)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104752/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 