'Re: Review Request: Fix regressions related to stacking order changes'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Fix regressions related to stacking order changes
From:       "Commit Hook" <null () kde ! org>
Date:       2012-04-24 20:05:54
Message-ID: 20120424200554.3101.12595 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104714/#review12887
-----------------------------------------------------------

This review has been submitted with commit fde0381bb1852793c4991def246b8bc0114e359d \
by Martin Gräßlin to branch master.

- Commit Hook

On April 24, 2012, 7:16 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104714/
> -----------------------------------------------------------
> 
> (Updated April 24, 2012, 7:16 p.m.)
> 
> 
> Review request for kwin.
> 
> 
> Description
> -------
> 
> Fix regressions related to stacking order changes
> 
> The change to have stacking order containing
> Toplevel inestead of Clients (431aad6d6994695e72697fcc3299ec2cb6f0684e)
> introduced possible crashers as recognized in:
> http://git.reviewboard.kde.org/r/104519/#review12714
> 
> This change fixes these issues by adding missing
> null pointer checks after casting to Client.
> 
> BUG: 298669
> FIXED-IN: 4.9.0
> 
> 
> This addresses bug 298669.
> http://bugs.kde.org/show_bug.cgi?id=298669
> 
> 
> Diffs
> -----
> 
> kwin/layers.cpp 589c940be575e3dfb5d6b305f1f275283cd3fe7b 
> 
> Diff: http://git.reviewboard.kde.org/r/104714/diff/
> 
> 
> Testing
> -------
> 
> It compiles, I somehow did not yet find a way to reproduce the crash reliable.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104714/">http://git.reviewboard.kde.org/r/104714/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit fde0381bb1852793c4991def246b8bc0114e359d by Martin Gräßlin to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On April 24th, 2012, 7:16 p.m., Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated April 24, 2012, 7:16 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix regressions related to stacking order changes

The change to have stacking order containing
Toplevel inestead of Clients (431aad6d6994695e72697fcc3299ec2cb6f0684e)
introduced possible crashers as recognized in:
http://git.reviewboard.kde.org/r/104519/#review12714

This change fixes these issues by adding missing
null pointer checks after casting to Client.

BUG: 298669
FIXED-IN: 4.9.0</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It compiles, I somehow did not yet find a way to reproduce the crash \
reliable.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=298669">298669</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/layers.cpp <span style="color: \
grey">(589c940be575e3dfb5d6b305f1f275283cd3fe7b)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104714/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 