'Re: Review Request: Adding proper clipping for transformed windows'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Adding proper clipping for transformed windows
From:       Martin_Gräßlin <kde () martin-graesslin ! com>
Date:       2012-04-24 18:23:59
Message-ID: 20120424182359.27527.45967 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104397/#review12877
-----------------------------------------------------------

Ship it!

Ship It!

- Martin Gr=C3=A4=C3=9Flin

On March 24, 2012, 12:06 p.m., Philipp Knechtges wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104397/
> -----------------------------------------------------------
> =

> (Updated March 24, 2012, 12:06 p.m.)
> =

> =

> Review request for kwin.
> =

> =

> Description
> -------
> =

> Since paintSimpleScreen can now paint transformed windows, which implies =
that these windows are also subject
> to occlusion culling, we have to reintroduce some proper clipping for the=
m. E.g. a transformed window
> that is hidden behind a always on top window might be painted to the back=
buffer although it is hidden.
> So far it is just not visible due to SceneOpenGL::flushBuffer not updatin=
g that area.
> =

> This patch reintroduces the usage of glScissor for all the former
> PAINT_SCREEN_WITH_TRANSFORMED_WINDOWS_WITHOUT_FULL_REPAINTS cases.
> My main rationale behind limiting it to these cases is to limit the numbe=
r of GL calls if there is no visible
> update of the screen, which is hopefully honored by the gfx power managem=
ent.
> =

> =

> Diffs
> -----
> =

>   kwin/lanczosfilter.cpp 010acc2ae55eb5ffa5fefce9ec4eb146e6536cde =

>   kwin/libkwineffects/kwingltexture.h ed24349af501a907864a64ffac487d48f5e=
f2de5 =

>   kwin/libkwineffects/kwingltexture.cpp 50a081025cd0719eafce7007734d225e9=
df88808 =

>   kwin/libkwineffects/kwinglutils.h c39f2dc361507ee8cc40a64fdce6027a359ed=
671 =

>   kwin/libkwineffects/kwinglutils.cpp 4102d3f1b4a15b467c79103d3fb1e153345=
906c2 =

>   kwin/scene_opengl.h 98d4dd41ad2994e6ef2f6f99cf6f00c20a918ef9 =

>   kwin/scene_opengl.cpp a0e0e0f4070f78b7bc0bc5a20b24bd90bc3f2f32 =

> =

> Diff: http://git.reviewboard.kde.org/r/104397/diff/
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Philipp Knechtges
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104397/">http://git.reviewboard.kde.org/r/104397/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Martin</p>

<br />
<p>On March 24th, 2012, 12:06 p.m., Philipp Knechtges wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Philipp Knechtges.</div>

<p style="color: grey;"><i>Updated March 24, 2012, 12:06 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Since paintSimpleScreen can now paint transformed windows, which implies \
that these windows are also subject to occlusion culling, we have to reintroduce some \
proper clipping for them. E.g. a transformed window that is hidden behind a always on \
top window might be painted to the backbuffer although it is hidden. So far it is \
just not visible due to SceneOpenGL::flushBuffer not updating that area.

This patch reintroduces the usage of glScissor for all the former
PAINT_SCREEN_WITH_TRANSFORMED_WINDOWS_WITHOUT_FULL_REPAINTS cases.
My main rationale behind limiting it to these cases is to limit the number of GL \
calls if there is no visible update of the screen, which is hopefully honored by the \
gfx power management.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/lanczosfilter.cpp <span style="color: \
grey">(010acc2ae55eb5ffa5fefce9ec4eb146e6536cde)</span></li>

 <li>kwin/libkwineffects/kwingltexture.h <span style="color: \
grey">(ed24349af501a907864a64ffac487d48f5ef2de5)</span></li>

 <li>kwin/libkwineffects/kwingltexture.cpp <span style="color: \
grey">(50a081025cd0719eafce7007734d225e9df88808)</span></li>

 <li>kwin/libkwineffects/kwinglutils.h <span style="color: \
grey">(c39f2dc361507ee8cc40a64fdce6027a359ed671)</span></li>

 <li>kwin/libkwineffects/kwinglutils.cpp <span style="color: \
grey">(4102d3f1b4a15b467c79103d3fb1e153345906c2)</span></li>

 <li>kwin/scene_opengl.h <span style="color: \
grey">(98d4dd41ad2994e6ef2f6f99cf6f00c20a918ef9)</span></li>

 <li>kwin/scene_opengl.cpp <span style="color: \
grey">(a0e0e0f4070f78b7bc0bc5a20b24bd90bc3f2f32)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104397/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 