[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: add screen inversion through XF86VidModeSetGammaRamp
From: "Commit Hook" <null () kde ! org>
Date: 2012-04-17 19:28:43
Message-ID: 20120417192843.19315.33964 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104371/#review12610
-----------------------------------------------------------
This review has been submitted with commit 24a6a569fd08b6308ac0ef240f93d5af=
32e8332c by Thomas L=C3=BCbking to branch master.
- Commit Hook
On March 30, 2012, 9:13 p.m., Thomas L=C3=BCbking wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104371/
> -----------------------------------------------------------
> =
> (Updated March 30, 2012, 9:13 p.m.)
> =
> =
> Review request for kwin, Martin Gr=C3=A4=C3=9Flin and Fredrik H=C3=B6glun=
d.
> =
> =
> Description
> -------
> =
> As proposed this allows to invert the screen with zero overhead or requir=
ement of OpenGL compositing.
> The patch depends on https://git.reviewboard.kde.org/r/103058/ which adds=
the libXxf86vm dependency (until i link out that nvidia refreshrate detect=
ion part)
> =
> Notice that it inverts the display colors - one cannot make an inverted s=
creenshot this way.
> =
> =
> Diffs
> -----
> =
> kwin/effects.h 994a89c =
> kwin/effects.cpp 8e73780 =
> kwin/effects/invert/invert.h d02a570 =
> kwin/effects/invert/invert.cpp e878516 =
> kwin/kwinbindings.cpp 3284cf0 =
> kwin/libkwineffects/kwineffects.h 1a6c7fc =
> kwin/useractions.cpp 09e18c3 =
> kwin/workspace.h 2e400ea =
> =
> Diff: http://git.reviewboard.kde.org/r/104371/diff/
> =
> =
> Testing
> -------
> =
> Inverts the screen.
> However there's an issue with the screen parameter. Neither active_screen=
nor QX11Info().screen() does work (unless on the primary screen, "0") - at=
least not on a TwinView setup.
> We have to try xrandr and xinerama, but it will linkey only work on indep=
endent screens or even X11 servers *shrug*
> =
> =
> Thanks,
> =
> Thomas L=C3=BCbking
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104371/">http://git.reviewboard.kde.org/r/104371/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 24a6a569fd08b6308ac0ef240f93d5af32e8332c by Thomas Lübking to \
branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On March 30th, 2012, 9:13 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Martin Gräßlin and Fredrik Höglund.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated March 30, 2012, 9:13 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As proposed this allows to invert the screen with zero overhead or \
requirement of OpenGL compositing. The patch depends on \
https://git.reviewboard.kde.org/r/103058/ which adds the libXxf86vm dependency (until \
i link out that nvidia refreshrate detection part)
Notice that it inverts the display colors - one cannot make an inverted screenshot \
this way.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Inverts the screen. However there's an issue with the screen \
parameter. Neither active_screen nor QX11Info().screen() does work (unless on the \
primary screen, "0") - at least not on a TwinView setup. We have to try \
xrandr and xinerama, but it will linkey only work on independent screens or even X11 \
servers *shrug*</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects.h <span style="color: grey">(994a89c)</span></li>
<li>kwin/effects.cpp <span style="color: grey">(8e73780)</span></li>
<li>kwin/effects/invert/invert.h <span style="color: grey">(d02a570)</span></li>
<li>kwin/effects/invert/invert.cpp <span style="color: grey">(e878516)</span></li>
<li>kwin/kwinbindings.cpp <span style="color: grey">(3284cf0)</span></li>
<li>kwin/libkwineffects/kwineffects.h <span style="color: \
grey">(1a6c7fc)</span></li>
<li>kwin/useractions.cpp <span style="color: grey">(09e18c3)</span></li>
<li>kwin/workspace.h <span style="color: grey">(2e400ea)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104371/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic