'Re: Review Request: Use desktop icon for Show Desktop entry in TabBox'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Use desktop icon for Show Desktop entry in TabBox
From:       "Commit Hook" <null () kde ! org>
Date:       2012-04-01 6:09:02
Message-ID: 20120401060902.765.50514 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104444/#review12085
-----------------------------------------------------------

This review has been submitted with commit cd746ce5af0524ac3233ad801ab833ce=
01fcd934 by Martin Gr=C3=A4=C3=9Flin to branch master.

- Commit Hook

On March 30, 2012, 6:18 a.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104444/
> -----------------------------------------------------------
> =

> (Updated March 30, 2012, 6:18 a.m.)
> =

> =

> Review request for kwin.
> =

> =

> Description
> -------
> =

> For the Show Desktop the desktop icon is used instead of the Plasma Cashe=
w. Makes more sense as Show Desktop Plasmoid also uses this icon.
> =

> =

> Diffs
> -----
> =

>   kwin/effects/coverswitch/coverswitch.h b7a9da3 =

>   kwin/effects/coverswitch/coverswitch.cpp fe517d0 =

>   kwin/effects/flipswitch/flipswitch.h f3fca73 =

>   kwin/effects/flipswitch/flipswitch.cpp a32c47c =

>   kwin/tabbox/tabbox.cpp c66aacd =

> =

> Diff: http://git.reviewboard.kde.org/r/104444/diff/
> =

> =

> Testing
> -------
> =

> Tried Layout, FlipSwitch and CoverSwitch
> =

> =

> Thanks,
> =

> Martin Gr=C3=A4=C3=9Flin
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104444/">http://git.reviewboard.kde.org/r/104444/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit cd746ce5af0524ac3233ad801ab833ce01fcd934 by Martin Gräßlin to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On March 30th, 2012, 6:18 a.m., Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated March 30, 2012, 6:18 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">For the Show Desktop the desktop icon is used instead of the Plasma \
Cashew. Makes more sense as Show Desktop Plasmoid also uses this icon.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tried Layout, FlipSwitch and CoverSwitch</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/effects/coverswitch/coverswitch.h <span style="color: \
grey">(b7a9da3)</span></li>

 <li>kwin/effects/coverswitch/coverswitch.cpp <span style="color: \
grey">(fe517d0)</span></li>

 <li>kwin/effects/flipswitch/flipswitch.h <span style="color: \
grey">(f3fca73)</span></li>

 <li>kwin/effects/flipswitch/flipswitch.cpp <span style="color: \
grey">(a32c47c)</span></li>

 <li>kwin/tabbox/tabbox.cpp <span style="color: grey">(c66aacd)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104444/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 