'Re: Review Request: Detect nvidia refresh rate using xvidmode'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Detect nvidia refresh rate using xvidmode
From:       "Commit Hook" <null () kde ! org>
Date:       2012-03-30 21:07:43
Message-ID: 20120330210743.10643.7820 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104442/#review12045
-----------------------------------------------------------

This review has been submitted with commit eb00905f8ff4ae19d2590078fe1e76ee=
b8ea1b80 by Thomas L=C3=BCbking to branch master.

- Commit Hook

On March 29, 2012, 8:25 p.m., Thomas L=C3=BCbking wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104442/
> -----------------------------------------------------------
> =

> (Updated March 29, 2012, 8:25 p.m.)
> =

> =

> Review request for kwin, Martin Gr=C3=A4=C3=9Flin and Fredrik H=C3=B6glun=
d.
> =

> =

> Description
> -------
> =

> This is a split part from the vsync swapping review, covering only linkin=
g xvidmode and using it to detect the refreshrate.
> Now supports interlaced screens and doublescanning resolutions (well, if =
it wor - that is. I don't possess such screen and doublescanning would only=
 be possible with < VGA on my remaining CRT - including freaking around wit=
h legacy Xorg stuff - i'd either remove it for what not is cannot be broken=
, or just wait for the first "kwin thinks i've a 30Hz screen bug". Refreshr=
ate however remained detected correctly here)
> =

> =

> Diffs
> -----
> =

>   kwin/CMakeLists.txt 463692d =

>   kwin/options.cpp 717a82d =

> =

> Diff: http://git.reviewboard.kde.org/r/104442/diff/
> =

> =

> Testing
> -------
> =

> Yes but for interlaced screens or doublescanning resolutions
> =

> =

> Thanks,
> =

> Thomas L=C3=BCbking
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104442/">http://git.reviewboard.kde.org/r/104442/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit eb00905f8ff4ae19d2590078fe1e76eeb8ea1b80 by Thomas Lübking to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On March 29th, 2012, 8:25 p.m., Thomas Lübking wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin, Martin Gräßlin and Fredrik Höglund.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated March 29, 2012, 8:25 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is a split part from the vsync swapping review, covering only \
linking xvidmode and using it to detect the refreshrate. Now supports interlaced \
screens and doublescanning resolutions (well, if it wor - that is. I don&#39;t \
possess such screen and doublescanning would only be possible with &lt; VGA on my \
remaining CRT - including freaking around with legacy Xorg stuff - i&#39;d either \
remove it for what not is cannot be broken, or just wait for the first &quot;kwin \
thinks i&#39;ve a 30Hz screen bug&quot;. Refreshrate however remained detected \
correctly here)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes but for interlaced screens or doublescanning resolutions</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/CMakeLists.txt <span style="color: grey">(463692d)</span></li>

 <li>kwin/options.cpp <span style="color: grey">(717a82d)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104442/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 