This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104371/

Review request for kwin, Martin Gräßlin and Fredrik Höglund.
By Thomas Lübking.

Updated March 30, 2012, 9:13 p.m.

Changes

provide patch accepted by reviewboard ...

Description

As proposed this allows to invert the screen with zero overhead or requirement of OpenGL compositing.
The patch depends on https://git.reviewboard.kde.org/r/103058/ which adds the libXxf86vm dependency (until i link out that nvidia refreshrate detection part)

Notice that it inverts the display colors - one cannot make an inverted screenshot this way.

Testing

Inverts the screen.
However there's an issue with the screen parameter. Neither active_screen nor QX11Info().screen() does work (unless on the primary screen, "0") - at least not on a TwinView setup.
We have to try xrandr and xinerama, but it will linkey only work on independent screens or even X11 servers *shrug*

Diffs (updated)

  • kwin/effects.h (994a89c)
  • kwin/effects.cpp (8e73780)
  • kwin/effects/invert/invert.h (d02a570)
  • kwin/effects/invert/invert.cpp (e878516)
  • kwin/kwinbindings.cpp (3284cf0)
  • kwin/libkwineffects/kwineffects.h (1a6c7fc)
  • kwin/useractions.cpp (09e18c3)
  • kwin/workspace.h (2e400ea)

View Diff