From kwin Fri Mar 30 21:13:10 2012 From: =?utf-8?q?Thomas_L=C3=BCbking?= Date: Fri, 30 Mar 2012 21:13:10 +0000 To: kwin Subject: Re: Review Request: add screen inversion through XF86VidModeSetGammaRamp Message-Id: <20120330211310.10859.16327 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=133314208421650 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============4015786747016447516==" --===============4015786747016447516== Content-Type: multipart/alternative; boundary="===============0731746864472508524==" --===============0731746864472508524== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104371/ ----------------------------------------------------------- (Updated March 30, 2012, 9:13 p.m.) Review request for kwin, Martin Gr=C3=A4=C3=9Flin and Fredrik H=C3=B6glund. Changes ------- provide patch accepted by reviewboard ... Description ------- As proposed this allows to invert the screen with zero overhead or requirem= ent of OpenGL compositing. The patch depends on https://git.reviewboard.kde.org/r/103058/ which adds t= he libXxf86vm dependency (until i link out that nvidia refreshrate detectio= n part) Notice that it inverts the display colors - one cannot make an inverted scr= eenshot this way. Diffs (updated) ----- kwin/effects.h 994a89c = kwin/effects.cpp 8e73780 = kwin/effects/invert/invert.h d02a570 = kwin/effects/invert/invert.cpp e878516 = kwin/kwinbindings.cpp 3284cf0 = kwin/libkwineffects/kwineffects.h 1a6c7fc = kwin/useractions.cpp 09e18c3 = kwin/workspace.h 2e400ea = Diff: http://git.reviewboard.kde.org/r/104371/diff/ Testing ------- Inverts the screen. However there's an issue with the screen parameter. Neither active_screen n= or QX11Info().screen() does work (unless on the primary screen, "0") - at l= east not on a TwinView setup. We have to try xrandr and xinerama, but it will linkey only work on indepen= dent screens or even X11 servers *shrug* Thanks, Thomas L=C3=BCbking --===============0731746864472508524== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/104371/

Review request for kwin, Martin Gr=C3=A4=C3=9Flin and Fredrik H=C3=B6g= lund.
By Thomas L=C3=BCbking.

Updated March 30, 2012, 9:13 p.m.

Changes
provide patch accepted by reviewboard ...

Descripti= on

As proposed this allows to invert the screen with zero overh=
ead or requirement of OpenGL compositing.
The patch depends on https://git.reviewboard.kde.org/r/103058/ which adds t=
he libXxf86vm dependency (until i link out that nvidia refreshrate detectio=
n part)

Notice that it inverts the display colors - one cannot make an inverted scr=
eenshot this way.

Testing <= /h1>
Inverts the screen.
However there's an issue with the screen parameter. Neither active_scre=
en nor QX11Info().screen() does work (unless on the primary screen, "0=
") - at least not on a TwinView setup.
We have to try xrandr and xinerama, but it will linkey only work on indepen=
dent screens or even X11 servers *shrug*

Diffs= (updated)

  • kwin/effects.h (994a89c)
  • kwin/effects.cpp (8e73780)
  • kwin/effects/invert/invert.h (d02a570)
  • kwin/effects/invert/invert.cpp (e878516)
  • kwin/kwinbindings.cpp (3284cf0)
  • kwin/libkwineffects/kwineffects.h (1a6c7fc= )
  • kwin/useractions.cpp (09e18c3)
  • kwin/workspace.h (2e400ea)

View Diff

--===============0731746864472508524==-- --===============4015786747016447516== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============4015786747016447516==--