[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: add screen inversion through XF86VidModeSetGammaRamp
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2012-03-30 13:08:00
Message-ID: 20120330130800.12373.53889 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On March 30, 2012, 8:25 a.m., Martin Gr=C3=A4=C3=9Flin wrote:
> > shouldn't we add a hook to the effect system so that if invert effect i=
s enabled (and useable) the invert effect is used instead?
Since this one comes without overhead and survives compositing state change=
s, i'd rather try to use it and fall back to the -if available- inversion e=
ffect in case libXxf86vm isn't available, by this removing the inversion ef=
fect specific shortcut.
Objections?
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104371/#review12000
-----------------------------------------------------------
On March 23, 2012, 1:20 a.m., Thomas L=C3=BCbking wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104371/
> -----------------------------------------------------------
> =
> (Updated March 23, 2012, 1:20 a.m.)
> =
> =
> Review request for kwin and Martin Gr=C3=A4=C3=9Flin.
> =
> =
> Description
> -------
> =
> As proposed this allows to invert the screen with zero overhead or requir=
ement of OpenGL compositing.
> The patch depends on https://git.reviewboard.kde.org/r/103058/ which adds=
the libXxf86vm dependency (until i link out that nvidia refreshrate detect=
ion part)
> =
> Notice that it inverts the display colors - one cannot make an inverted s=
creenshot this way.
> =
> =
> Diffs
> -----
> =
> kwin/workspace.h 1c6a831 =
> kwin/kwinbindings.cpp 3284cf0 =
> kwin/useractions.cpp dfb6fd4 =
> =
> Diff: http://git.reviewboard.kde.org/r/104371/diff/
> =
> =
> Testing
> -------
> =
> Inverts the screen.
> However there's an issue with the screen parameter. Neither active_screen=
nor QX11Info().screen() does work (unless on the primary screen, "0") - at=
least not on a TwinView setup.
> We have to try xrandr and xinerama, but it will linkey only work on indep=
endent screens or even X11 servers *shrug*
> =
> =
> Thanks,
> =
> Thomas L=C3=BCbking
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104371/">http://git.reviewboard.kde.org/r/104371/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 30th, 2012, 8:25 a.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">shouldn't we add a hook to the effect system so that if invert \
effect is enabled (and useable) the invert effect is used instead?</pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since this one comes \
without overhead and survives compositing state changes, i'd rather try to use it \
and fall back to the -if available- inversion effect in case libXxf86vm isn't \
available, by this removing the inversion effect specific shortcut. Objections?</pre>
<br />
<p>- Thomas</p>
<br />
<p>On March 23rd, 2012, 1:20 a.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated March 23, 2012, 1:20 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As proposed this allows to invert the screen with zero overhead or \
requirement of OpenGL compositing. The patch depends on \
https://git.reviewboard.kde.org/r/103058/ which adds the libXxf86vm dependency (until \
i link out that nvidia refreshrate detection part)
Notice that it inverts the display colors - one cannot make an inverted screenshot \
this way.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Inverts the screen. However there's an issue with the screen \
parameter. Neither active_screen nor QX11Info().screen() does work (unless on the \
primary screen, "0") - at least not on a TwinView setup. We have to try \
xrandr and xinerama, but it will linkey only work on independent screens or even X11 \
servers *shrug*</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/workspace.h <span style="color: grey">(1c6a831)</span></li>
<li>kwin/kwinbindings.cpp <span style="color: grey">(3284cf0)</span></li>
<li>kwin/useractions.cpp <span style="color: grey">(dfb6fd4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104371/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic