[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Drop Decorations B2, Laptop and Plastik
From:       Martin_Gräßlin <kde () martin-graesslin ! com>
Date:       2012-03-29 9:27:35
Message-ID: 20120329092735.21652.4904 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104281/
-----------------------------------------------------------

(Updated March 29, 2012, 9:27 a.m.)


Review request for kwin and Plasma.


Changes
-------

Now also dropping Laptop as discussed on mailinglist. Laptop is as broken as Plastik \
and we need a new decoration for thin clients.


Summary (updated)
-----------------

Drop Decorations B2, Laptop and Plastik


Description
-------

As discussed on mailinglist: http://lists.kde.org/?l=kwin&m=133136239707091&w=2


Diffs (updated)
-----

  kwin/clients/CMakeLists.txt 6019a9e 
  kwin/clients/b2/CMakeLists.txt 9295cbe 
  kwin/clients/b2/b2.desktop 2846e39 
  kwin/clients/b2/b2client.h c9e9b57 
  kwin/clients/b2/b2client.cpp 6b52996 
  kwin/clients/b2/bitmaps.h 00c4552 
  kwin/clients/b2/config/CMakeLists.txt 1aaf8da 
  kwin/clients/b2/config/config.h c5bc33c 
  kwin/clients/b2/config/config.cpp fc9c7b9 
  kwin/clients/laptop/CMakeLists.txt 1f4d600 
  kwin/clients/laptop/laptop.desktop ccc9d54 
  kwin/clients/laptop/laptopclient.h 4f1196d 
  kwin/clients/laptop/laptopclient.cpp 52efcd1 
  kwin/clients/plastik/CMakeLists.txt fce0829 
  kwin/clients/plastik/config/CMakeLists.txt e48955d 
  kwin/clients/plastik/config/config.h b037efe 
  kwin/clients/plastik/config/config.cpp a4ddfe0 
  kwin/clients/plastik/config/configdialog.ui fe9f53a 
  kwin/clients/plastik/plastik.h ae7a46e 
  kwin/clients/plastik/plastik.cpp ff9825f 
  kwin/clients/plastik/plastik.desktop 30550c6 
  kwin/clients/plastik/plastikbutton.h 395f628 
  kwin/clients/plastik/plastikbutton.cpp db29d76 
  kwin/clients/plastik/plastikclient.h 4c5b0d9 
  kwin/clients/plastik/plastikclient.cpp 58f8324 

Diff: http://git.reviewboard.kde.org/r/104281/diff/


Testing
-------

it compiles


Thanks,

Martin Gräßlin


[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104281/">http://git.reviewboard.kde.org/r/104281/</a>
  </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Plasma.</div>
<div>By Martin Gräßlin.</div>


<p style="color: grey;"><i>Updated March 29, 2012, 9:27 a.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Now also dropping Laptop as discussed on mailinglist. Laptop is as \
broken as Plastik and we need a new decoration for thin clients.</pre>  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Summary \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Drop Decorations B2, Laptop and Plastik</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As discussed on mailinglist: \
http://lists.kde.org/?l=kwin&amp;m=133136239707091&amp;w=2</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">it compiles</pre>  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/clients/CMakeLists.txt <span style="color: grey">(6019a9e)</span></li>

 <li>kwin/clients/b2/CMakeLists.txt <span style="color: grey">(9295cbe)</span></li>

 <li>kwin/clients/b2/b2.desktop <span style="color: grey">(2846e39)</span></li>

 <li>kwin/clients/b2/b2client.h <span style="color: grey">(c9e9b57)</span></li>

 <li>kwin/clients/b2/b2client.cpp <span style="color: grey">(6b52996)</span></li>

 <li>kwin/clients/b2/bitmaps.h <span style="color: grey">(00c4552)</span></li>

 <li>kwin/clients/b2/config/CMakeLists.txt <span style="color: \
grey">(1aaf8da)</span></li>

 <li>kwin/clients/b2/config/config.h <span style="color: grey">(c5bc33c)</span></li>

 <li>kwin/clients/b2/config/config.cpp <span style="color: \
grey">(fc9c7b9)</span></li>

 <li>kwin/clients/laptop/CMakeLists.txt <span style="color: \
grey">(1f4d600)</span></li>

 <li>kwin/clients/laptop/laptop.desktop <span style="color: \
grey">(ccc9d54)</span></li>

 <li>kwin/clients/laptop/laptopclient.h <span style="color: \
grey">(4f1196d)</span></li>

 <li>kwin/clients/laptop/laptopclient.cpp <span style="color: \
grey">(52efcd1)</span></li>

 <li>kwin/clients/plastik/CMakeLists.txt <span style="color: \
grey">(fce0829)</span></li>

 <li>kwin/clients/plastik/config/CMakeLists.txt <span style="color: \
grey">(e48955d)</span></li>

 <li>kwin/clients/plastik/config/config.h <span style="color: \
grey">(b037efe)</span></li>

 <li>kwin/clients/plastik/config/config.cpp <span style="color: \
grey">(a4ddfe0)</span></li>

 <li>kwin/clients/plastik/config/configdialog.ui <span style="color: \
grey">(fe9f53a)</span></li>

 <li>kwin/clients/plastik/plastik.h <span style="color: grey">(ae7a46e)</span></li>

 <li>kwin/clients/plastik/plastik.cpp <span style="color: grey">(ff9825f)</span></li>

 <li>kwin/clients/plastik/plastik.desktop <span style="color: \
grey">(30550c6)</span></li>

 <li>kwin/clients/plastik/plastikbutton.h <span style="color: \
grey">(395f628)</span></li>

 <li>kwin/clients/plastik/plastikbutton.cpp <span style="color: \
grey">(db29d76)</span></li>

 <li>kwin/clients/plastik/plastikclient.h <span style="color: \
grey">(4c5b0d9)</span></li>

 <li>kwin/clients/plastik/plastikclient.cpp <span style="color: \
grey">(58f8324)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104281/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>



_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic