[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Restrict repaints of AnimationEffect
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2012-03-28 21:31:32
Message-ID: 20120328213132.25788.5085 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On March 25, 2012, 8:38 p.m., Philipp Knechtges wrote:
> > kwin/libkwineffects/kwinanimationeffect.cpp, lines 139-141
> > <http://git.reviewboard.kde.org/r/103932/diff/2/?file=54493#file54493line139>
> >
> > style
Ok, the Qt coding style requires braces if either branch covers multiple lines.
I'll fix that before commit.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103932/#review11842
-----------------------------------------------------------
On March 28, 2012, 9:22 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103932/
> -----------------------------------------------------------
>
> (Updated March 28, 2012, 9:22 p.m.)
>
>
> Review request for kwin, Martin Gräßlin and Philipp Knechtges.
>
>
> Description
> -------
>
> Upstream port of the current GenericAnimation effect implementation, but introduces \
> an export of the decorationRect (instead of that 48px padding hack) - thus pointing \
> master (breaks ABI)
>
> Diffs
> -----
>
> kwin/libkwineffects/kwineffects.h 1a6c7fc
> kwin/libkwineffects/kwineffects.cpp 135c9ae
> kwin/toplevel.h 32581a5
> kwin/toplevel.cpp 00bd7dd
> kwin/libkwineffects/kwinanimationeffect.h 61dea35
> kwin/libkwineffects/kwinanimationeffect.cpp ee0772d
> kwin/effects.h 994a89c
> kwin/effects.cpp 8e73780
>
> Diff: http://git.reviewboard.kde.org/r/103932/diff/
>
>
> Testing
> -------
>
> Yes, everyday - except for the decorationRect() change, will do so next.
>
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103932/">http://git.reviewboard.kde.org/r/103932/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 25th, 2012, 8:38 p.m., <b>Philipp \
Knechtges</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103932/diff/2/?file=54493#file54493line139" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/libkwineffects/kwinanimationeffect.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
AnimationEffect::animate( EffectWindow *w, Attribute a, uint meta, int ms, FPx2 to, \
QEasingCurve curve, int delay, FPx2 from )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">135</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="p">}</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">138</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="p">}</span><span \
class="hl"> </span><span class="k"><span class="hl">else</span></span></pre></td> \
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">136</font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">else</span></pre></td> <th bgcolor="#ebb1ba" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th> \
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">137</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">from</span><span class="p">.</span><span class="n">set</span><span \
class="p">(</span><span class="n">w</span><span class="o">-></span><span \
class="n">width</span><span class="p">(),</span> <span class="n">w</span><span \
class="o">-></span><span class="n">height</span><span \
class="p">());</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">139</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">from</span><span \
class="p">.</span><span class="n">set</span><span class="p">(</span><span \
class="n">w</span><span class="o">-></span><span class="n">width</span><span \
class="p">(),</span> <span class="n">w</span><span class="o">-></span><span \
class="n">height</span><span class="p">());</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">style</pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, the Qt \
coding style requires braces if either branch covers multiple lines. I'll fix \
that before commit.</pre> <br />
<p>- Thomas</p>
<br />
<p>On March 28th, 2012, 9:22 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Martin Gräßlin and Philipp Knechtges.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated March 28, 2012, 9:22 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Upstream port of the current GenericAnimation effect implementation, but \
introduces an export of the decorationRect (instead of that 48px padding hack) - thus \
pointing master (breaks ABI)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes, everyday - except for the decorationRect() change, will do so \
next.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/libkwineffects/kwineffects.h <span style="color: \
grey">(1a6c7fc)</span></li>
<li>kwin/libkwineffects/kwineffects.cpp <span style="color: \
grey">(135c9ae)</span></li>
<li>kwin/toplevel.h <span style="color: grey">(32581a5)</span></li>
<li>kwin/toplevel.cpp <span style="color: grey">(00bd7dd)</span></li>
<li>kwin/libkwineffects/kwinanimationeffect.h <span style="color: \
grey">(61dea35)</span></li>
<li>kwin/libkwineffects/kwinanimationeffect.cpp <span style="color: \
grey">(ee0772d)</span></li>
<li>kwin/effects.h <span style="color: grey">(994a89c)</span></li>
<li>kwin/effects.cpp <span style="color: grey">(8e73780)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103932/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic