'Re: Review Request: Providing clipping for the tabbox window thumbnails'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Providing clipping for the tabbox window thumbnails
From:       "Philipp Knechtges" <philipp-dev () knechtges ! com>
Date:       2012-03-26 20:04:40
Message-ID: 20120326200440.1456.6144 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104399/
-----------------------------------------------------------

(Updated March 26, 2012, 8:04 p.m.)

Review request for kwin and Martin Gr=C3=A4=C3=9Flin.

Changes
-------

- adjusting to latest upstream
- do the clipping in a less hacky way

Description
-------

This patch is based on https://git.reviewboard.kde.org/r/104397/
and introduces clipping for the window thumbnails which are only partially =
visible.

Diffs (updated)
-----

  kwin/scene.cpp 4e69121 =

  kwin/tabbox/qml/clients/present_windows/contents/ui/main.qml 988091a =

Diff: http://git.reviewboard.kde.org/r/104399/diff/

Testing
-------

works :)

Screenshots
-----------

Thumbnail Clipping
  http://git.reviewboard.kde.org/r/104399/s/490/

Thanks,

Philipp Knechtges

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104399/">http://git.reviewboard.kde.org/r/104399/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Philipp Knechtges.</div>

<p style="color: grey;"><i>Updated March 26, 2012, 8:04 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">- adjusting to latest upstream
- do the clipping in a less hacky way</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch is based on https://git.reviewboard.kde.org/r/104397/ and \
introduces clipping for the window thumbnails which are only partially visible.</pre> \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">works :)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/scene.cpp <span style="color: grey">(4e69121)</span></li>

 <li>kwin/tabbox/qml/clients/present_windows/contents/ui/main.qml <span style="color: \
grey">(988091a)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104399/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>

<div>

 <a href="http://git.reviewboard.kde.org/r/104399/s/490/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/03/24/PicThumbnailClipping_400x100.png" \
style="border: 1px black solid;" alt="Thumbnail Clipping" /></a>

</div>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 