--===============6752379988711913569== Content-Type: multipart/alternative; boundary="===============7031068482952112308==" --===============7031068482952112308== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104395/#review11836 ----------------------------------------------------------- This review has been submitted with commit 4aa0b5b229221444b6df63a3fefe274b= 38b49f01 by Martin Gr=C3=A4=C3=9Flin to branch master. - Commit Hook On March 24, 2012, 9:44 a.m., Martin Gr=C3=A4=C3=9Flin wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104395/ > ----------------------------------------------------------- > = > (Updated March 24, 2012, 9:44 a.m.) > = > = > Review request for kwin. > = > = > Description > ------- > = > Instead of using the scene it is better to use the toplevel item's parent= position. This works better in case the scene > is endless and the toplevel item is not positioned at 0/0 as it is the ca= se for anything from Plasma. > = > There are still slight layouting issues which I think is caused by thumbn= ails not honouring the margin. Will investigate. > = > = > Diffs > ----- > = > kwin/scene.cpp 2a2d0b8 = > = > Diff: http://git.reviewboard.kde.org/r/104395/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Martin Gr=C3=A4=C3=9Flin > = > --===============7031068482952112308== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/104395/

This revie=
w has been submitted with commit 4aa0b5b229221444b6df63a3fefe274b38b49f01 b=
y Martin Gr=C3=A4=C3=9Flin to branch master.

- Commit

On March 24th, 2012, 9:44 a.m., Martin Gr=C3=A4=C3=9Flin wrote:

Review request for kwin.

By Martin Gr=C3=A4=C3=9Flin.

Updated March 24, 2012, 9:44 a.m.

Descripti= on

Instead of using the scene it is better to use the toplevel =
item's parent position. This works better in case the scene
is endless and the toplevel item is not positioned at 0/0 as it is the case=
 for anything from Plasma.

There are still slight layouting issues which I think is caused by thumbnai=
ls not honouring the margin. Will investigate.

Diffs=

kwin/scene.cpp (2a2d0b8)

View Diff

--===============7031068482952112308==-- --===============6752379988711913569== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============6752379988711913569==--