--===============1038803850835351454== Content-Type: multipart/alternative; boundary="===============1032851114016956549==" --===============1032851114016956549== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104394/#review11835 ----------------------------------------------------------- This review has been submitted with commit b4e4ec361c9fd38760c5c41c10bbad80= a49a7836 by Martin Gr=C3=A4=C3=9Flin to branch master. - Commit Hook On March 24, 2012, 11:28 a.m., Martin Gr=C3=A4=C3=9Flin wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104394/ > ----------------------------------------------------------- > = > (Updated March 24, 2012, 11:28 a.m.) > = > = > Review request for kwin. > = > = > Description > ------- > = > ThumbnailItem tries to find the window where it is embedded in through a = context propery containing the window id of the declarative > view. This works fine for e.g. TabBox but not for Plasma.Dialog as that o= pens a new window. > = > = > Diffs > ----- > = > kwin/thumbnailitem.h e50c973 = > kwin/thumbnailitem.cpp b402b32 = > = > Diff: http://git.reviewboard.kde.org/r/104394/diff/ > = > = > Testing > ------- > = > Thumbnails can be rendered on Plasma.Dialog > = > = > Thanks, > = > Martin Gr=C3=A4=C3=9Flin > = > --===============1032851114016956549== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/104394/

This revie=
w has been submitted with commit b4e4ec361c9fd38760c5c41c10bbad80a49a7836 b=
y Martin Gr=C3=A4=C3=9Flin to branch master.

- Commit

On March 24th, 2012, 11:28 a.m., Martin Gr=C3=A4=C3=9Flin wrote:

Review request for kwin.

By Martin Gr=C3=A4=C3=9Flin.

Updated March 24, 2012, 11:28 a.m.

Descripti= on

ThumbnailItem tries to find the window where it is embedded =
in through a context propery containing the window id of the declarative
view. This works fine for e.g. TabBox but not for Plasma.Dialog as that ope=
ns a new window.

Testing <= /h1>

Thumbnails can be rendered on Plasma.Dialog

Diffs=

kwin/thumbnailitem.h (e50c973)
kwin/thumbnailitem.cpp (b402b32)

View Diff

--===============1032851114016956549==-- --===============1038803850835351454== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============1038803850835351454==--