'Re: Review Request: Use an ActionGroup for Move To Desktop entries'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Use an ActionGroup for Move To Desktop entries
From:       "Commit Hook" <null () kde ! org>
Date:       2012-03-25 11:01:45
Message-ID: 20120325110145.27468.31265 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104378/#review11834
-----------------------------------------------------------

This review has been submitted with commit e899342b069dbb99cdc6527f23baf347=
359d4650 by Martin Gr=C3=A4=C3=9Flin to branch master.

- Commit Hook

On March 23, 2012, 7:19 a.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104378/
> -----------------------------------------------------------
> =

> (Updated March 23, 2012, 7:19 a.m.)
> =

> =

> Review request for kwin and Plasma.
> =

> =

> Description
> -------
> =

> Virtual Desktops are mutual exclusive, so an ActionGroup
> is better suited.
> =

> Diff is too big, because review board did not like my parent diffs :-( It=
 includes what I have in two other requests, too.
> =

> =

> Diffs
> -----
> =

>   kwin/useractions.cpp dfb6fd4 =

>   libs/taskmanager/taskactions.cpp e6f9c26 =

> =

> Diff: http://git.reviewboard.kde.org/r/104378/diff/
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Martin Gr=C3=A4=C3=9Flin
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104378/">http://git.reviewboard.kde.org/r/104378/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit e899342b069dbb99cdc6527f23baf347359d4650 by Martin Gräßlin to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On March 23rd, 2012, 7:19 a.m., Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Plasma.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated March 23, 2012, 7:19 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Virtual Desktops are mutual exclusive, so an ActionGroup is better \
suited.

Diff is too big, because review board did not like my parent diffs :-( It includes \
what I have in two other requests, too.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/useractions.cpp <span style="color: grey">(dfb6fd4)</span></li>

 <li>libs/taskmanager/taskactions.cpp <span style="color: grey">(e6f9c26)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104378/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 