'Re: Review Request: Use Show desktop item instead of empty text in TabBox'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Use Show desktop item instead of empty text in TabBox
From:       "Commit Hook" <null () kde ! org>
Date:       2012-03-25 10:00:38
Message-ID: 20120325100038.24133.61863 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104379/#review11831
-----------------------------------------------------------

This review has been submitted with commit cb2c6fd491af7e4135a804ed83cf4acdda9fb54a \
by Martin Gräßlin to branch master.

- Commit Hook

On March 23, 2012, 7:40 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104379/
> -----------------------------------------------------------
> 
> (Updated March 23, 2012, 7:40 a.m.)
> 
> 
> Review request for kwin.
> 
> 
> Description
> -------
> 
> If there are no windows for Alt+Tab the Show Desktop entry
> is shown. This works better with both layouts and effects.
> Before this change effects were not activated at all but
> a fallback to the layouts was used. Concerning the layouts
> some looked rather bad. E.g. Thumbnails did not show a
> thumbnail but a legacy text had been shown.
> 
> When a window gets added to the empty list, the show desktop
> window is removed and consequently when the last window goes
> away the show desktop entry is added again.
> 
> There is a not considered corner case: if there is no desktop
> window, the show desktop functionality is not available and
> the behavior is unfortunately undefined. It is a corner case
> as we can expect that there is always a desktop window when
> using KWin. E.g. there is either Plasma Desktop or Netbook
> and on PA there is always at least one window.
> 
> 
> This addresses bug 260938.
> http://bugs.kde.org/show_bug.cgi?id=260938
> 
> 
> Diffs
> -----
> 
> kwin/tabbox/clientmodel.h 450d665 
> kwin/tabbox/clientmodel.cpp eae1cfa 
> kwin/tabbox/declarative.cpp a470fe8 
> kwin/tabbox/tabboxhandler.cpp e91ea71 
> 
> Diff: http://git.reviewboard.kde.org/r/104379/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104379/">http://git.reviewboard.kde.org/r/104379/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit cb2c6fd491af7e4135a804ed83cf4acdda9fb54a by Martin Gräßlin to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On March 23rd, 2012, 7:40 a.m., Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated March 23, 2012, 7:40 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">If there are no windows for Alt+Tab the Show Desktop entry is shown. \
This works better with both layouts and effects. Before this change effects were not \
activated at all but a fallback to the layouts was used. Concerning the layouts
some looked rather bad. E.g. Thumbnails did not show a
thumbnail but a legacy text had been shown.

When a window gets added to the empty list, the show desktop
window is removed and consequently when the last window goes
away the show desktop entry is added again.

There is a not considered corner case: if there is no desktop
window, the show desktop functionality is not available and
the behavior is unfortunately undefined. It is a corner case
as we can expect that there is always a desktop window when
using KWin. E.g. there is either Plasma Desktop or Netbook
and on PA there is always at least one window.</pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=260938">260938</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/tabbox/clientmodel.h <span style="color: grey">(450d665)</span></li>

 <li>kwin/tabbox/clientmodel.cpp <span style="color: grey">(eae1cfa)</span></li>

 <li>kwin/tabbox/declarative.cpp <span style="color: grey">(a470fe8)</span></li>

 <li>kwin/tabbox/tabboxhandler.cpp <span style="color: grey">(e91ea71)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104379/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 