'Re: Review Request: Global Shortcut support for KWin Scripts'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Global Shortcut support for KWin Scripts
From:       Martin_Gräßlin <kde () martin-graesslin ! com>
Date:       2012-03-25 8:03:37
Message-ID: 20120325080337.19941.8054 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104400/
-----------------------------------------------------------

(Updated March 25, 2012, 8:03 a.m.)

Review request for kwin.

Changes
-------

Added shortcuts also to scripted effects. Most of the shared code went into template \
functions in a new file scriptingutils.h. Nevertheless I'm quite unhappy with the \
code duplication and will think about a better solution.

Description
-------

Scripts can register callbacks for global shortcuts.

Needs to be made available to scripted effects, too.

Diffs (updated)
-----

  kwin/scripting/scriptedeffect.h b0080ba 
  kwin/scripting/scriptedeffect.cpp cc0cf73 
  kwin/scripting/scripting.h 67184b4 
  kwin/scripting/scripting.cpp b5b1a2e 
  kwin/scripting/scriptingutils.h PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/104400/diff/

Testing
-------

var callback = function() {
  print("Global Shortcut triggered in script");
};

registerShortcut("Test", "This is the title to test", "Ctrl+Alt+7", callback);

Thanks,

Martin Gräßlin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104400/">http://git.reviewboard.kde.org/r/104400/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated March 25, 2012, 8:03 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Added shortcuts also to scripted effects. Most of the shared code went \
into template functions in a new file scriptingutils.h. Nevertheless I&#39;m quite \
unhappy with the code duplication and will think about a better solution.</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Scripts can register callbacks for global shortcuts.

Needs to be made available to scripted effects, too.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">var callback = function() {  print(&quot;Global Shortcut triggered in \
script&quot;); };

registerShortcut(&quot;Test&quot;, &quot;This is the title to test&quot;, \
&quot;Ctrl+Alt+7&quot;, callback); </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/scripting/scriptedeffect.h <span style="color: grey">(b0080ba)</span></li>

 <li>kwin/scripting/scriptedeffect.cpp <span style="color: \
grey">(cc0cf73)</span></li>

 <li>kwin/scripting/scripting.h <span style="color: grey">(67184b4)</span></li>

 <li>kwin/scripting/scripting.cpp <span style="color: grey">(b5b1a2e)</span></li>

 <li>kwin/scripting/scriptingutils.h <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104400/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 