[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Do not use GraphicsScene to calculate Thumbnail position
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2012-03-24 20:56:10
Message-ID: 20120324205610.15946.38886 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On March 24, 2012, 5:34 p.m., Thomas L=C3=BCbking wrote:
> > Semi unrelated question: since this code is in the core (for the tabbox=
etc.) - do we actually still need the taskbar thumbnail effect and could w=
e eventually utilize this for the thumbnail aside effect (which is more or =
less broken and a "little" unpolished anyway, ie. it could create mini inpu=
t windows, break minimization and be used as "minimize to -movable" thumbna=
il window" - i think there's somewhere a wish in this direction)
taskbar thumbnail seems difficult to me as long as the taskbar tooltips are=
part of the plasma process. The code actually inspects the properties of t=
he QML script, so we would need to have the code for it. Personally I wante=
d to have the complete tooltip moved to KWin for a long time.
About Thumbnail Aside I had been thinking today due to the addition of the =
global shortcuts. This allows to have them completely in JavaScript or QML.=
So yeah having them better would be nice and having them movable around th=
e screen could be really neat :-)
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104395/#review11813
-----------------------------------------------------------
On March 24, 2012, 9:44 a.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104395/
> -----------------------------------------------------------
> =
> (Updated March 24, 2012, 9:44 a.m.)
> =
> =
> Review request for kwin.
> =
> =
> Description
> -------
> =
> Instead of using the scene it is better to use the toplevel item's parent=
position. This works better in case the scene
> is endless and the toplevel item is not positioned at 0/0 as it is the ca=
se for anything from Plasma.
> =
> There are still slight layouting issues which I think is caused by thumbn=
ails not honouring the margin. Will investigate.
> =
> =
> Diffs
> -----
> =
> kwin/scene.cpp 2a2d0b8 =
> =
> Diff: http://git.reviewboard.kde.org/r/104395/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Martin Gr=C3=A4=C3=9Flin
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104395/">http://git.reviewboard.kde.org/r/104395/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 24th, 2012, 5:34 p.m., <b>Thomas \
Lübking</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Semi unrelated question: since this code is in the core (for the tabbox \
etc.) - do we actually still need the taskbar thumbnail effect and could we \
eventually utilize this for the thumbnail aside effect (which is more or less broken \
and a "little" unpolished anyway, ie. it could create mini input windows, \
break minimization and be used as "minimize to -movable" thumbnail \
window" - i think there's somewhere a wish in this direction)</pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">taskbar thumbnail seems \
difficult to me as long as the taskbar tooltips are part of the plasma process. The \
code actually inspects the properties of the QML script, so we would need to have the \
code for it. Personally I wanted to have the complete tooltip moved to KWin for a \
long time.
About Thumbnail Aside I had been thinking today due to the addition of the global \
shortcuts. This allows to have them completely in JavaScript or QML. So yeah having \
them better would be nice and having them movable around the screen could be really \
neat :-)</pre> <br />
<p>- Martin</p>
<br />
<p>On March 24th, 2012, 9:44 a.m., Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated March 24, 2012, 9:44 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Instead of using the scene it is better to use the toplevel item's \
parent position. This works better in case the scene is endless and the toplevel item \
is not positioned at 0/0 as it is the case for anything from Plasma.
There are still slight layouting issues which I think is caused by thumbnails not \
honouring the margin. Will investigate.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/scene.cpp <span style="color: grey">(2a2d0b8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104395/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic