'Review Request: Use an ActionGroup for Move To Desktop entries'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Review Request: Use an ActionGroup for Move To Desktop entries
From:       Martin_Gräßlin <kde () martin-graesslin ! com>
Date:       2012-03-23 7:19:46
Message-ID: 20120323071946.19249.15933 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104378/
-----------------------------------------------------------

Review request for kwin and Plasma.

Description
-------

Virtual Desktops are mutual exclusive, so an ActionGroup
is better suited.

Diff is too big, because review board did not like my parent diffs :-( It i=
ncludes what I have in two other requests, too.

Diffs
-----

  kwin/useractions.cpp dfb6fd4 =

  libs/taskmanager/taskactions.cpp e6f9c26 =

Diff: http://git.reviewboard.kde.org/r/104378/diff/

Testing
-------

Thanks,

Martin Gr=C3=A4=C3=9Flin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104378/">http://git.reviewboard.kde.org/r/104378/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Plasma.</div>
<div>By Martin Gräßlin.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Virtual Desktops are mutual exclusive, so an ActionGroup is better \
suited.

Diff is too big, because review board did not like my parent diffs :-( It includes \
what I have in two other requests, too.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/useractions.cpp <span style="color: grey">(dfb6fd4)</span></li>

 <li>libs/taskmanager/taskactions.cpp <span style="color: grey">(e6f9c26)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104378/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 