From kwin Thu Mar 22 06:35:59 2012 From: =?utf-8?q?Martin_Gr=C3=A4=C3=9Flin?= Date: Thu, 22 Mar 2012 06:35:59 +0000 To: kwin Subject: Re: Review Request: Improve appearance of the compact layout switcher Message-Id: <20120322063559.4770.95665 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=133239823903780 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7609139374881075278==" --===============7609139374881075278== Content-Type: multipart/alternative; boundary="===============7764052586412904802==" --===============7764052586412904802== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104187/#review11733 ----------------------------------------------------------- Ship it! Ship It! - Martin Gr=C3=A4=C3=9Flin On March 21, 2012, 11:04 p.m., Aur=C3=A9lien G=C3=A2teau wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104187/ > ----------------------------------------------------------- > = > (Updated March 21, 2012, 11:04 p.m.) > = > = > Review request for kwin. > = > = > Description > ------- > = > This patch improves (IMO) the appearance of the compact layout switcher: > = > - Do not use bold for all texts. Using bold everywhere ends up not emphas= izing anything. > = > - Only uses desaturated icons for minimized windows. Right now only the a= ctive window has a colored icon, causing the whole window to look very gray. > = > = > Diffs > ----- > = > kwin/tabbox/qml/clients/compact/contents/ui/main.qml 9504789 = > = > Diff: http://git.reviewboard.kde.org/r/104187/diff/ > = > = > Testing > ------- > = > Tested on both 4.8 and master branches. I would like to see this go in 4.= 8 as well. > = > = > Screenshots > ----------- > = > Before > http://git.reviewboard.kde.org/r/104187/s/450/ > After > http://git.reviewboard.kde.org/r/104187/s/451/ > After 2 > http://git.reviewboard.kde.org/r/104187/s/483/ > = > = > Thanks, > = > Aur=C3=A9lien G=C3=A2teau > = > --===============7764052586412904802== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/104187/

Ship it!

Ship It!
 








- Martin




On March 21st, 2012, 11:04 p.m., Aur=C3=A9lien G=C3=A2teau wrote:







 
  

Review request for kwin.
By Aur=C3=A9lien G=C3=A2teau.


Updated March 21, 2012, 11:04 p.m.






Descripti=
on 
 
 
  
   This patch improves (IMO) the appearance of the compact layo=
ut switcher:

- Do not use bold for all texts. Using bold everywhere ends up not emphasiz=
ing anything.

- Only uses desaturated icons for minimized windows. Right now only the act=
ive window has a colored icon, causing the whole window to look very gray.<=
/pre>
  
 



Testing <=
/h1>

 
  
   Tested on both 4.8 and master branches. I would like to see =
this go in 4.8 as well.
  
 





Diffs=
 


 kwin/tabbox/qml/clients/compact/contents/ui/main.qml (9504789)



View Diff



Screensho=
ts

--===============7764052586412904802==-- --===============7609139374881075278== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============7609139374881075278==--

Descripti= on

Testing <= /h1> Tested on both 4.8 and master branches. I would like to see = this go in 4.8 as well.

Diffs=

Screensho= ts

Testing <= /h1>

Tested on both 4.8 and master branches. I would like to see = this go in 4.8 as well.