'Re: Review Request: Improve appearance of the compact layout switcher'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Improve appearance of the compact layout switcher
From:       Aurélien Gâteau <agateau () kde ! org>
Date:       2012-03-21 23:04:33
Message-ID: 20120321230433.10378.51003 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104187/
-----------------------------------------------------------

(Updated March 21, 2012, 11:04 p.m.)

Review request for kwin.

Changes
-------

Finally, here is a new version, which includes the suggestions from Thomas.

Description
-------

This patch improves (IMO) the appearance of the compact layout switcher:

- Do not use bold for all texts. Using bold everywhere ends up not emphasiz=
ing anything.

- Only uses desaturated icons for minimized windows. Right now only the act=
ive window has a colored icon, causing the whole window to look very gray.

Diffs (updated)
-----

  kwin/tabbox/qml/clients/compact/contents/ui/main.qml 9504789 =

Diff: http://git.reviewboard.kde.org/r/104187/diff/

Testing
-------

Tested on both 4.8 and master branches. I would like to see this go in 4.8 =
as well.

Screenshots (updated)
-----------

Before
  http://git.reviewboard.kde.org/r/104187/s/450/
After
  http://git.reviewboard.kde.org/r/104187/s/451/
After 2
  http://git.reviewboard.kde.org/r/104187/s/483/

Thanks,

Aur=C3=A9lien G=C3=A2teau

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104187/">http://git.reviewboard.kde.org/r/104187/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Aurélien Gâteau.</div>

<p style="color: grey;"><i>Updated March 21, 2012, 11:04 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Finally, here is a new version, which includes the suggestions from \
Thomas.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch improves (IMO) the appearance of the compact layout switcher:

- Do not use bold for all texts. Using bold everywhere ends up not emphasizing \
anything.

- Only uses desaturated icons for minimized windows. Right now only the active window \
has a colored icon, causing the whole window to look very gray.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested on both 4.8 and master branches. I would like to see this go in \
4.8 as well.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/tabbox/qml/clients/compact/contents/ui/main.qml <span style="color: \
grey">(9504789)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104187/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots \
(updated)</h1>

<div>

 <a href="http://git.reviewboard.kde.org/r/104187/s/450/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/03/07/tab-switcher-compact-layout-before_400x100.png" \
style="border: 1px black solid;" alt="Before" /></a>

 <a href="http://git.reviewboard.kde.org/r/104187/s/451/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/03/07/tab-switcher-compact-layout-after_400x100.png" \
style="border: 1px black solid;" alt="After" /></a>

 <a href="http://git.reviewboard.kde.org/r/104187/s/483/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/03/21/tabbox-after_400x100.png" \
style="border: 1px black solid;" alt="After 2" /></a>

</div>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 