[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Do not animate the highlight the first time the tabbox is shown
From: "Commit Hook" <null () kde ! org>
Date: 2012-03-20 23:02:32
Message-ID: 20120320230232.9822.49144 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104340/#review11670
-----------------------------------------------------------
This review has been submitted with commit 76d24ca7feb613413d3d6f307191b6c5=
fad78d50 by Albert Astals Cid to branch master.
- Commit Hook
On March 18, 2012, 10:16 p.m., Albert Astals Cid wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104340/
> -----------------------------------------------------------
> =
> (Updated March 18, 2012, 10:16 p.m.)
> =
> =
> Review request for kwin.
> =
> =
> Description
> -------
> =
> Since using the KDE 4.8 qml tabbox i get very confused using the tabbox b=
ecause of the initial highlight animation. Check this situation:
> * Have 5 programs running
> * Use Alt+tab to select the last one
> * Now press Alt+tab again
> * See how the highlight travels back from the 5th to the 2nd position in=
the tabbox
> This means that most of the times i end up ultra confused by the highligh=
t travelling in the wrong direction and i select the wrong program.
> =
> This patch "disables" the animation the first time the tabbox is shown (a=
ctually makes the animation it happen in 1msec)
> =
> The code is mostly a hack. If you like the idea of that initial animation=
not happening i'm open to implementing it in the best way you can think if=
you don't like this one.
> =
> =
> Diffs
> -----
> =
> kwin/tabbox/declarative.h 5674054 =
> kwin/tabbox/declarative.cpp f7a9c98 =
> kwin/tabbox/tabboxhandler.cpp 0e8ad89 =
> =
> Diff: http://git.reviewboard.kde.org/r/104340/diff/
> =
> =
> Testing
> -------
> =
> Opened and closed the tabbox, now it's "immediate" the first time and has=
the nice animation all the other times.
> =
> =
> Thanks,
> =
> Albert Astals Cid
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104340/">http://git.reviewboard.kde.org/r/104340/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 76d24ca7feb613413d3d6f307191b6c5fad78d50 by Albert Astals Cid \
to branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On March 18th, 2012, 10:16 p.m., Albert Astals Cid wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Albert Astals Cid.</div>
<p style="color: grey;"><i>Updated March 18, 2012, 10:16 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Since using the KDE 4.8 qml tabbox i get very confused using the tabbox \
because of the initial highlight animation. Check this situation:
* Have 5 programs running
* Use Alt+tab to select the last one
* Now press Alt+tab again
* See how the highlight travels back from the 5th to the 2nd position in the tabbox
This means that most of the times i end up ultra confused by the highlight travelling \
in the wrong direction and i select the wrong program.
This patch "disables" the animation the first time the tabbox is shown \
(actually makes the animation it happen in 1msec)
The code is mostly a hack. If you like the idea of that initial animation not \
happening i'm open to implementing it in the best way you can think if you \
don't like this one.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Opened and closed the tabbox, now it's "immediate" the \
first time and has the nice animation all the other times.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/tabbox/declarative.h <span style="color: grey">(5674054)</span></li>
<li>kwin/tabbox/declarative.cpp <span style="color: grey">(f7a9c98)</span></li>
<li>kwin/tabbox/tabboxhandler.cpp <span style="color: grey">(0e8ad89)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104340/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic