From kwin Tue Mar 13 21:07:27 2012 From: =?utf-8?q?Thomas_L=C3=BCbking?= Date: Tue, 13 Mar 2012 21:07:27 +0000 To: kwin Subject: Re: Review Request: Add offscreen rendering support to xrender backend Message-Id: <20120313210727.19264.60563 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=133167291011384 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============4326649825253521411==" --===============4326649825253521411== Content-Type: multipart/alternative; boundary="===============2721647491617419197==" --===============2721647491617419197== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104151/ ----------------------------------------------------------- (Updated March 13, 2012, 9:07 p.m.) Review request for kwin and Martin Gr=C3=A4=C3=9Flin. Changes ------- - fixed a bug - added gl-a-like push/popTarget routines for persistent offscreen buffers I'll update the "ship it" in two days and push then. Description ------- Still applies to 4.8 and is ABI stable (i think - no issue with non-recompi= led 3rd party effects) but technically a new feature... Anyway, we'll need such for forthcoming "kwin core animates activation chan= ge" effects (actually i want crossfading for more occasions) but as a quick= POC, i implemented the screenshot effect as well ;-) I'm not sure about the requirement of a stack as in glrendertarget - this w= ould not be an issue to implement. -> rationale? Diffs (updated) ----- kwin/libkwineffects/kwinxrenderutils.h b094389 = kwin/libkwineffects/kwinxrenderutils.cpp bc58705 = kwin/scene_xrender.cpp b2a11c8 = Diff: http://git.reviewboard.kde.org/r/104151/diff/ Testing ------- Yupp, see screenshot request Thanks, Thomas L=C3=BCbking --===============2721647491617419197== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/104151/

Review request for kwin and Martin Gr=C3=A4=C3=9Flin.
By Thomas L=C3=BCbking.

Updated March 13, 2012, 9:07 p.m.

Changes 
- fixed a bug
- added gl-a-like push/popTarget routines for persistent offscreen buffers

I'll update the "ship it" in two days and push then.

Descripti= on 

Still applies to 4.8 and is ABI stable (i think - no issue w=
ith non-recompiled 3rd party effects) but technically a new feature...

Anyway, we'll need such for forthcoming "kwin core animates activa=
tion change" effects (actually i want crossfading for more occasions) =
but as a quick POC, i implemented the screenshot effect as well ;-)

I'm not sure about the requirement of a stack as in glrendertarget - th=
is would not be an issue to implement.
-> rationale?

Testing <= /h1> 
Yupp, see screenshot request

Diffs= (updated)

  • kwin/libkwineffects/kwinxrenderutils.h (b0= 94389)
  • kwin/libkwineffects/kwinxrenderutils.cpp (= bc58705)
  • kwin/scene_xrender.cpp (b2a11c8)

View Diff
--===============2721647491617419197==-- --===============4326649825253521411== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============4326649825253521411==--