'Review Request: remove overzealous maxmode_restore'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Review Request: remove overzealous maxmode_restore
From:       Thomas_Lübking <thomas.luebking () web ! de>
Date:       2012-03-11 7:49:01
Message-ID: 20120311074901.16103.99538 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104219/
-----------------------------------------------------------

Review request for kwin and Martin Gräßlin.

Description
-------

The variable changes the behavior of the lmb maximization.
I have frankly no idea why that was added (git blame points me to lubos compositor -> \
master commit) but the result is really weird (you send a restore and get a half \
restore)

This addresses bug 195576.
    http://bugs.kde.org/show_bug.cgi?id=195576

Diffs
-----

  kwin/client.h bdebe44 
  kwin/client.cpp 22aa8dc 
  kwin/geometry.cpp d9ae97a 

Diff: http://git.reviewboard.kde.org/r/104219/diff/

Testing
-------

Yes, at least for the decoration button there's no way a regression.
Since partial maximization is unknown to other OS, i doubt there's much programmatic \
usage of that feature which could harm. However i don't know why it was introduced \
and therefore would rather target 4.9, while personally wouldn't mind 4.8 either ;-)

Thanks,

Thomas Lübking

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104219/">http://git.reviewboard.kde.org/r/104219/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The variable changes the behavior of the lmb maximization. I have \
frankly no idea why that was added (git blame points me to lubos compositor -&gt; \
master commit) but the result is really weird (you send a restore and get a half \
restore)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes, at least for the decoration button there&#39;s no way a regression. \
Since partial maximization is unknown to other OS, i doubt there&#39;s much \
programmatic usage of that feature which could harm. However i don&#39;t know why it \
was introduced and therefore would rather target 4.9, while personally wouldn&#39;t \
mind 4.8 either ;-) </pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=195576">195576</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/client.h <span style="color: grey">(bdebe44)</span></li>

 <li>kwin/client.cpp <span style="color: grey">(22aa8dc)</span></li>

 <li>kwin/geometry.cpp <span style="color: grey">(d9ae97a)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104219/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 