'Re: Review Request: Script to keep a part of the panel visible in fullscreen windows'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Script to keep a part of the panel visible in fullscreen windows
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2012-03-09 17:49:25
Message-ID: 20120309174925.8225.19508 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104205/#review11256
-----------------------------------------------------------

Ship it!

- Marco Martin

On March 9, 2012, 5:36 p.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104205/
> -----------------------------------------------------------
> =

> (Updated March 9, 2012, 5:36 p.m.)
> =

> =

> Review request for kwin and Marco Martin.
> =

> =

> Description
> -------
> =

> As discussed yesterday at Plasma Active sprint: a script which keeps part=
s of the panel visible (currently 5). I have not yet tried it on an active =
device but at least on the notebook it works that the panel is still visibl=
e.
> =

> This script could be improved by making the pixels configurable, e.g. dev=
ices were it is possible to swipe from above the touchscreen could go to a =
one pixel margin. But before I do that I would like to have it tested first=
 by the PA group :-)
> =

> =

> Diffs
> -----
> =

>   kwin/scripts/CMakeLists.txt 2b1d360 =

>   kwin/scripts/fullscreen-panel/contents/code/main.js PRE-CREATION =

>   kwin/scripts/fullscreen-panel/metadata.desktop PRE-CREATION =

> =

> Diff: http://git.reviewboard.kde.org/r/104205/diff/
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Martin Gr=C3=A4=C3=9Flin
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104205/">http://git.reviewboard.kde.org/r/104205/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

<p>- Marco</p>

<br />
<p>On March 9th, 2012, 5:36 p.m., Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Marco Martin.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated March 9, 2012, 5:36 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As discussed yesterday at Plasma Active sprint: a script which keeps \
parts of the panel visible (currently 5). I have not yet tried it on an active device \
but at least on the notebook it works that the panel is still visible.

This script could be improved by making the pixels configurable, e.g. devices were it \
is possible to swipe from above the touchscreen could go to a one pixel margin. But \
before I do that I would like to have it tested first by the PA group :-)</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/scripts/CMakeLists.txt <span style="color: grey">(2b1d360)</span></li>

 <li>kwin/scripts/fullscreen-panel/contents/code/main.js <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>kwin/scripts/fullscreen-panel/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104205/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 