[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: QML scripts and desktop change OSD ported to QML
From: "Commit Hook" <null () kde ! org>
Date: 2012-03-02 8:11:15
Message-ID: 20120302081115.21891.98606 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104037/#review11071
-----------------------------------------------------------
This review has been submitted with commit 7dc28692d33ef36563dcf327e8f2caf3=
b0ea328e by Martin Gr=C3=A4=C3=9Flin to branch master.
- Commit Hook
On March 1, 2012, 10:32 a.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104037/
> -----------------------------------------------------------
> =
> (Updated March 1, 2012, 10:32 a.m.)
> =
> =
> Review request for kwin.
> =
> =
> Description
> -------
> =
> Scripting bindings extended to support QML. As a proof of concept the des=
ktop change OSD is rewritten in QML. What's currently missing is reading co=
nfig options. This is something I will add next and adjust the KCM and add =
an kconf update script.
> =
> =
> Diffs
> -----
> =
> kwin/CMakeLists.txt cba139b =
> kwin/desktopchangeosd.h 9c75205 =
> kwin/desktopchangeosd.cpp 04eac92 =
> kwin/kcmkwin/kwindesktop/main.cpp 21ff017 =
> kwin/kcmkwin/kwinscripts/module.cpp a3084a4 =
> kwin/scripting/kwinscript.desktop 04519ef =
> kwin/scripting/scripting.h f716ae6 =
> kwin/scripting/scripting.cpp 180991b =
> kwin/scripts/CMakeLists.txt ccde1fc =
> kwin/scripts/desktopchangeosd/contents/ui/main.qml PRE-CREATION =
> kwin/scripts/desktopchangeosd/metadata.desktop PRE-CREATION =
> kwin/workspace.h cb1c139 =
> kwin/workspace.cpp 8d6135b =
> =
> Diff: http://git.reviewboard.kde.org/r/104037/diff/
> =
> =
> Testing
> -------
> =
> changed desktops quite a lot
> =
> =
> Thanks,
> =
> Martin Gr=C3=A4=C3=9Flin
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104037/">http://git.reviewboard.kde.org/r/104037/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 7dc28692d33ef36563dcf327e8f2caf3b0ea328e by Martin Gräßlin to \
branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On March 1st, 2012, 10:32 a.m., Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated March 1, 2012, 10:32 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Scripting bindings extended to support QML. As a proof of concept the \
desktop change OSD is rewritten in QML. What's currently missing is reading \
config options. This is something I will add next and adjust the KCM and add an kconf \
update script.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">changed desktops quite a lot</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/CMakeLists.txt <span style="color: grey">(cba139b)</span></li>
<li>kwin/desktopchangeosd.h <span style="color: grey">(9c75205)</span></li>
<li>kwin/desktopchangeosd.cpp <span style="color: grey">(04eac92)</span></li>
<li>kwin/kcmkwin/kwindesktop/main.cpp <span style="color: \
grey">(21ff017)</span></li>
<li>kwin/kcmkwin/kwinscripts/module.cpp <span style="color: \
grey">(a3084a4)</span></li>
<li>kwin/scripting/kwinscript.desktop <span style="color: \
grey">(04519ef)</span></li>
<li>kwin/scripting/scripting.h <span style="color: grey">(f716ae6)</span></li>
<li>kwin/scripting/scripting.cpp <span style="color: grey">(180991b)</span></li>
<li>kwin/scripts/CMakeLists.txt <span style="color: grey">(ccde1fc)</span></li>
<li>kwin/scripts/desktopchangeosd/contents/ui/main.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/scripts/desktopchangeosd/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/workspace.h <span style="color: grey">(cb1c139)</span></li>
<li>kwin/workspace.cpp <span style="color: grey">(8d6135b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104037/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic