'Re: Review Request: Build option for KActivities'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Build option for KActivities
From:       Martin_Gräßlin <kde () martin-graesslin ! com>
Date:       2012-02-28 5:58:31
Message-ID: 20120228055831.9475.46367 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104100/
-----------------------------------------------------------

(Updated Feb. 28, 2012, 5:58 a.m.)

Review request for kwin.

Changes
-------

* fixed typo

Description
-------

Rational: I'm currently trying to get KWin build standalone, that is not as=
 part of workspace. Why? As an experiment to see if it is possible and to h=
ave it easier to build it for things like my Pandaboard or the N950. For th=
at I'm cutting a little bit on dependencies. For all these patches I don't =
mind if I'm told it's not for master

This is a patch to make KActivities support optional at build time.

Diffs (updated)
-----

  kwin/CMakeLists.txt cba139b =

  kwin/activation.cpp 8e9be65 =

  kwin/config-kwin.h.cmake 8893fa4 =

  kwin/useractions.cpp a1fec6c =

  kwin/workspace.h cb1c139 =

  kwin/workspace.cpp 8d6135b =

Diff: http://git.reviewboard.kde.org/r/104100/diff/

Testing
-------

compiles

Thanks,

Martin Gr=C3=A4=C3=9Flin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104100/">http://git.reviewboard.kde.org/r/104100/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Feb. 28, 2012, 5:58 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">* fixed typo</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Rational: I&#39;m currently trying to get KWin build standalone, that is \
not as part of workspace. Why? As an experiment to see if it is possible and to have \
it easier to build it for things like my Pandaboard or the N950. For that I&#39;m \
cutting a little bit on dependencies. For all these patches I don&#39;t mind if \
I&#39;m told it&#39;s not for master

This is a patch to make KActivities support optional at build time.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">compiles</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/CMakeLists.txt <span style="color: grey">(cba139b)</span></li>

 <li>kwin/activation.cpp <span style="color: grey">(8e9be65)</span></li>

 <li>kwin/config-kwin.h.cmake <span style="color: grey">(8893fa4)</span></li>

 <li>kwin/useractions.cpp <span style="color: grey">(a1fec6c)</span></li>

 <li>kwin/workspace.h <span style="color: grey">(cb1c139)</span></li>

 <li>kwin/workspace.cpp <span style="color: grey">(8d6135b)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104100/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 