[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: make sure the tapped window gets activated
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2012-02-27 20:27:11
Message-ID: 20120227202711.11177.63290 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104096/#review10968
-----------------------------------------------------------
kwin/tabbox/declarative.cpp
<http://git.reviewboard.kde.org/r/104096/#comment8906>
minor nitpick: Wid is a qulonglog, so toInt seems dangerous :-)
- Martin Gr=C3=A4=C3=9Flin
On Feb. 27, 2012, 4:54 p.m., Marco Martin wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104096/
> -----------------------------------------------------------
> =
> (Updated Feb. 27, 2012, 4:54 p.m.)
> =
> =
> Review request for kwin.
> =
> =
> Description
> -------
> =
> if when the tabbox is open another window that does -not- appear in the t=
abbox gets focus, tapping on the same thumbnail as the last active window w=
on't produce any effect, the patch makes sure that window gets activated, e=
ven if it has the currentIndex
> =
> =
> Diffs
> -----
> =
> kwin/tabbox/declarative.cpp 9d00404 =
> =
> Diff: http://git.reviewboard.kde.org/r/104096/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Marco Martin
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104096/">http://git.reviewboard.kde.org/r/104096/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/104096/diff/1/?file=51244#file51244line322" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/tabbox/declarative.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
DeclarativeView::setCurrentIndex(const QModelIndex &index)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">322</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">KWindowSystem</span><span class="o">::</span><span \
class="n">forceActiveWindow</span><span class="p">(</span><span \
class="n">m_model</span><span class="o">-></span><span class="n">data</span><span \
class="p">(</span><span class="n">m_model</span><span class="o">-></span><span \
class="n">index</span><span class="p">(</span><span class="n">row</span><span \
class="p">,</span> <span class="mi">0</span><span class="p">),</span> <span \
class="n">ClientModel</span><span class="o">::</span><span \
class="n">WIdRole</span><span class="p">).</span><span class="n">toInt</span><span \
class="p">());</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">minor \
nitpick: Wid is a qulonglog, so toInt seems dangerous :-)</pre> </div>
<br />
<p>- Martin</p>
<br />
<p>On February 27th, 2012, 4:54 p.m., Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Feb. 27, 2012, 4:54 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">if when the tabbox is open another window that does -not- appear in the \
tabbox gets focus, tapping on the same thumbnail as the last active window won't \
produce any effect, the patch makes sure that window gets activated, even if it has \
the currentIndex</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/tabbox/declarative.cpp <span style="color: grey">(9d00404)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104096/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic