This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104095/

kwin/tabbox/declarative.cpp (Diff revision 1)
along with this program.  If not, see <http://www.gnu.org/licenses/>.
48
#include <X11/extensions/XInput2.h>
this should probably be ifdefed or do we have XInput2 as a generic dependency of workspace?

kwin/tabbox/declarative.cpp (Diff revision 1)
DeclarativeView::DeclarativeView(QAbstractItemModel *model, TabBoxConfig::TabBoxMode mode, QWidget *parent)
154
*cough* :-)

kwin/tabbox/declarative.cpp (Diff revision 1)
bool DeclarativeView::x11Event(XEvent *e)
231
    } else if (e->type == GenericEvent) {
232
        XEvent ev;
233
        XIDeviceEvent *dev = (XIDeviceEvent *)e->xcookie.data;
234
could we get some comments here what the code actually does?

kwin/tabbox/declarative.cpp (Diff revision 1)
bool DeclarativeView::x11Event(XEvent *e)
263
    } 
*cough* :-)

- Martin


On February 27th, 2012, 4:54 p.m., Marco Martin wrote:

Review request for kwin.
By Marco Martin.

Updated Feb. 27, 2012, 4:54 p.m.

Description

on systems with multitouch support, x11Event() won't get any mouse event (even for actual mouse events) but will get only xi2 events.
this translates those xi2 events to mouse events and sends them to the embedding window, making possible to drag the embedding window on multitouch systems.

Testing

the problem could be dependency from xi2.
however i think that x11Event() not getting mouse events can potentially cause problems elsewhere too, focus assignment after click seems a bit buggy on multitouch systems

Diffs

  • kwin/tabbox/declarative.cpp (60effb9e)

View Diff