From kwin Mon Feb 27 20:25:04 2012 From: =?utf-8?q?Martin_Gr=C3=A4=C3=9Flin?= Date: Mon, 27 Feb 2012 20:25:04 +0000 To: kwin Subject: Re: Review Request: send mouse events translated from touch event to the tabbox embedding window Message-Id: <20120227202504.10940.9884 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=133037434310934 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============4782417363157390478==" --===============4782417363157390478== Content-Type: multipart/alternative; boundary="===============1995020122174575452==" --===============1995020122174575452== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104095/#review10965 ----------------------------------------------------------- kwin/tabbox/declarative.cpp this should probably be ifdefed or do we have XInput2 as a generic depe= ndency of workspace? kwin/tabbox/declarative.cpp *cough* :-) kwin/tabbox/declarative.cpp could we get some comments here what the code actually does? kwin/tabbox/declarative.cpp *cough* :-) - Martin Gr=C3=A4=C3=9Flin On Feb. 27, 2012, 4:54 p.m., Marco Martin wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104095/ > ----------------------------------------------------------- > = > (Updated Feb. 27, 2012, 4:54 p.m.) > = > = > Review request for kwin. > = > = > Description > ------- > = > on systems with multitouch support, x11Event() won't get any mouse event = (even for actual mouse events) but will get only xi2 events. > this translates those xi2 events to mouse events and sends them to the em= bedding window, making possible to drag the embedding window on multitouch = systems. > = > = > Diffs > ----- > = > kwin/tabbox/declarative.cpp 60effb9e = > = > Diff: http://git.reviewboard.kde.org/r/104095/diff/ > = > = > Testing > ------- > = > the problem could be dependency from xi2. > however i think that x11Event() not getting mouse events can potentially = cause problems elsewhere too, focus assignment after click seems a bit bugg= y on multitouch systems > = > = > Thanks, > = > Marco Martin > = > --===============1995020122174575452== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/104095/

= =
kwin/tabbox/declarative.cpp (Diff revision 1) 
along with this program.  If not, see <http://www.gnu.org/licens=
es/>.
 

    48
    
#include <X11/extensions=
/XInput2.h>

  


 





this should probably be ifdefed or do we have XInput2 as a generic d=
ependency of workspace?

















 =

 =




 

 
  

   
    kwin/tabbox/declarative.cpp
    

     (Diff revision 1)

    
   
  

 

 
  


   
DeclarativeView::DeclarativeView(QAbstractItemModel *model, TabBoxC=
onfig::TabBoxMode mode, QWidget *parent)


  

 

  

    
    

    154
    

  


 





*cough* :-)

















 =

 =




 

 
  

   
    kwin/tabbox/declarative.cpp
    

     (Diff revision 1)

    
   
  

 

 
  


   
bool DeclarativeView::x11Event(XEvent *e)


  

 

  

    
    

    231
    
    } else if (e->type =3D=3D GenericEvent<=
span class=3D"p">) {

  


  

    
    

    232
    
        XEvent ev;

  


  

    
    

    233
    
        XIDeviceEvent=
 *dev =
=3D (XIDeviceEvent=
 *)e->xcookie.data;

  


  

    
    

    234
    

  


 





could we get some comments here what the code actually does?

















 =

 =




 

 
  

   
    kwin/tabbox/declarative.cpp
    

     (Diff revision 1)

    
   
  

 

 
  


   
bool DeclarativeView::x11Event(XEvent *e)


  

 

  

    
    

    263
    
    } 

  


 





*cough* :-)









- Martin






On February 27th, 2012, 4:54 p.m., Marco Martin wrote:









 

  


Review request for kwin.


By Marco Martin.




Updated Feb. 27, 2012, 4:54 p.m.








Descripti=
on 

 

 

  
   
on systems with multitouch support, x11Event() won't get=
 any mouse event (even for actual mouse events) but will get only xi2 event=
s.
this translates those xi2 events to mouse events and sends them to the embe=
dding window, making possible to drag the embedding window on multitouch sy=
stems.



  		
 






Testing <=
/h1>


 

  
   
the problem could be dependency from xi2.
however i think that x11Event() not getting mouse events can potentially ca=
use problems elsewhere too, focus assignment after click seems a bit buggy =
on multitouch systems

  		
 








Diffs=
 


    

 
  • kwin/tabbox/declarative.cpp (60effb9e)
    • 





View Diff





  		
 











  

 



--===============1995020122174575452==--

--===============4782417363157390478==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

--===============4782417363157390478==--