'Re: Review Request: Drop include for config-workspace.h'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Drop include for config-workspace.h
From:       "Commit Hook" <null () kde ! org>
Date:       2012-02-26 16:24:37
Message-ID: 20120226162437.29452.46408 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104081/#review10914
-----------------------------------------------------------

This review has been submitted with commit ecee428da7e8a7897c26a20d5b6e0607=
5674dccb by Martin Gr=C3=A4=C3=9Flin to branch master.

- Commit Hook

On Feb. 26, 2012, 11:37 a.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104081/
> -----------------------------------------------------------
> =

> (Updated Feb. 26, 2012, 11:37 a.m.)
> =

> =

> Review request for kwin.
> =

> =

> Description
> -------
> =

> searched for all ifdefs used in kwin and none of them is defined in confi=
g-workspace.h. Given that kwin clean compiles without these includes I assu=
me kwin does not use any of the other definitions provided in config-worksp=
ace.h
> =

> =

> Diffs
> -----
> =

>   kwin/libkwineffects/kwinglobals.cpp 575813e =

>   kwin/scene_xrender.h 76d4088 =

>   kwin/utils.h 8a7d9a1 =

> =

> Diff: http://git.reviewboard.kde.org/r/104081/diff/
> =

> =

> Testing
> -------
> =

> compiles
> =

> =

> Thanks,
> =

> Martin Gr=C3=A4=C3=9Flin
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104081/">http://git.reviewboard.kde.org/r/104081/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit ecee428da7e8a7897c26a20d5b6e06075674dccb by Martin Gräßlin to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On February 26th, 2012, 11:37 a.m., Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Feb. 26, 2012, 11:37 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">searched for all ifdefs used in kwin and none of them is defined in \
config-workspace.h. Given that kwin clean compiles without these includes I assume \
kwin does not use any of the other definitions provided in config-workspace.h</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">compiles</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/libkwineffects/kwinglobals.cpp <span style="color: \
grey">(575813e)</span></li>

 <li>kwin/scene_xrender.h <span style="color: grey">(76d4088)</span></li>

 <li>kwin/utils.h <span style="color: grey">(8a7d9a1)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104081/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 