[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Remove saturation from fragment shader in GLES
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2012-02-25 8:52:41
Message-ID: 20120225085241.30119.14251 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Feb. 25, 2012, 2:53 a.m., Thomas L=C3=BCbking wrote:
> > Errhemmm - meeehhh....
> > It hits at least every nvidia chip between NV40 & NV80 and AMD R500 & R=
600 which you put into one class with GMA945 ...
> > =
> > Tried to query glGetString(GL_SHADING_LANGUAGE_VERSION) ?
> > http://www.opengl.org/registry/specs/ARB/shading_language_100.txt
I'm not sure what the extension would help there. I assume that the driver =
implements the language even if the underlying hardware does not support ev=
erything.
Maybe we need to be more specific in the enum to specify whether the hardwa=
re supports branches in the fragment shader.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103227/#review10882
-----------------------------------------------------------
On Feb. 24, 2012, 7:57 a.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103227/
> -----------------------------------------------------------
> =
> (Updated Feb. 24, 2012, 7:57 a.m.)
> =
> =
> Review request for kwin, Marco Martin and Fredrik H=C3=B6glund.
> =
> =
> Description
> -------
> =
> ifdef the saturation branch in the fragment shader for gles. Reason: hard=
ware probably does not support branches and at least the exopc gains a perf=
ormance improvement on gles when the branch is dropped.
> =
> As it means a regression compared to 4.7 for hardware with branch support=
in fragment shader on gles I'm only targeting master.
> =
> KWin on GLX is unchanged.
> =
> =
> Diffs
> -----
> =
> kwin/libkwineffects/kwingltexture.cpp 50a0810 =
> kwin/libkwineffects/kwinglutils.cpp 4102d3f =
> kwin/scene-fragment.glsl 4b5424b =
> =
> Diff: http://git.reviewboard.kde.org/r/103227/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Martin Gr=C3=A4=C3=9Flin
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103227/">http://git.reviewboard.kde.org/r/103227/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 25th, 2012, 2:53 a.m., <b>Thomas \
Lübking</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Errhemmm - meeehhh.... It hits at least every nvidia chip between NV40 \
& NV80 and AMD R500 & R600 which you put into one class with GMA945 ...
Tried to query glGetString(GL_SHADING_LANGUAGE_VERSION) ?
http://www.opengl.org/registry/specs/ARB/shading_language_100.txt</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not sure what \
the extension would help there. I assume that the driver implements the language even \
if the underlying hardware does not support everything.
Maybe we need to be more specific in the enum to specify whether the hardware \
supports branches in the fragment shader.</pre> <br />
<p>- Martin</p>
<br />
<p>On February 24th, 2012, 7:57 a.m., Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Marco Martin and Fredrik Höglund.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Feb. 24, 2012, 7:57 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">ifdef the saturation branch in the fragment shader for gles. Reason: \
hardware probably does not support branches and at least the exopc gains a \
performance improvement on gles when the branch is dropped.
As it means a regression compared to 4.7 for hardware with branch support in fragment \
shader on gles I'm only targeting master.
KWin on GLX is unchanged.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/libkwineffects/kwingltexture.cpp <span style="color: \
grey">(50a0810)</span></li>
<li>kwin/libkwineffects/kwinglutils.cpp <span style="color: \
grey">(4102d3f)</span></li>
<li>kwin/scene-fragment.glsl <span style="color: grey">(4b5424b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103227/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic