[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Only reserve required electric borders for ElectricAlways
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2012-02-25 1:59:04
Message-ID: 20120225015904.9054.21262 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Feb. 25, 2012, 12:03 a.m., Philip Turmel wrote:
> > Did not work in 1x4 with virtualbox. Mouse flickered between vbox style and kwin \
> > style at the edge. Vbox mini-toolbar would not pop down.
> > I don't know how to debug in more detail, but I did review the diff. I'm \
> > concerned that your changes to ScreenEdge::reserveDesktopSwitching() are not \
> > maintaining the balance of reserve vs. unreserve counts. Reservation is not a \
> > boolean property.
> > Also, as can be seen in my competing patch, the information needed to \
> > reserve/unreserve just the needed edges is accessible from within the routines \
> > that need it, without an API change.
> > Finally, this solution doesn't appear to examine the ignore/follow pager layout \
> > setting from the effects, and therefore doesn't offer the functionality I've \
> > requested. I'm aware that isn't universally desired, but I can't recommend your \
> > solution if it doesn't address my needs.
The API change is there because geometry.cpp needs to allocate all borders when \
moving a window (maximization, quick tiling etc.) and is no problem at all. We don't \
need ABI stability in the core and it's preserved by the effect lib (where ABI is \
usually but not necessarily preserved in minor versions) the same way as you do - by \
not exporting the function, resp. not changing the signature (that is not necessary)
The ignore/follow pager is no global setting but provided by some effects \
independently. Now, if you want to allow ignoring the layout, the entire setting \
should just go and be replaced by adding next/prev resp. up/down/left/right hooks to \
each border since that is what it would become.
However and as mentioned in the bug my opinion remains that particular pagers may \
deviate from the generally set layout regarding their particular needs or options. A \
general ignore option thus makes hardly sense and ignoring it here should better be \
done by breaking up the borders and removing ::reserveDesktopSwitching() altogether
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104073/#review10880
-----------------------------------------------------------
On Feb. 25, 2012, 1:49 a.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104073/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2012, 1:49 a.m.)
>
>
> Review request for kwin, Martin Gräßlin and Philip Turmel.
>
>
> Description
> -------
>
> In competition to http://git.reviewboard.kde.org/r/104070/
> This only reserves the electric borders that are actually required, depending on \
> the configured desktop matrix.
> I tested, but Philip should best try VBox as well
>
>
> This addresses bug 293011.
> http://bugs.kde.org/show_bug.cgi?id=293011
>
>
> Diffs
> -----
>
> kwin/desktoplayout.cpp 7578559
> kwin/effects.h f4ad2fb
> kwin/effects.cpp 6c252c9
> kwin/geometry.cpp d9ae97a
> kwin/libkwineffects/kwineffects.h 780cc89
> kwin/scene.cpp 0541198
> kwin/screenedge.h cf08164
> kwin/screenedge.cpp 9734a1e
> kwin/workspace.h d5942dc
> kwin/workspace.cpp b4fd277
>
> Diff: http://git.reviewboard.kde.org/r/104073/diff/
>
>
> Testing
> -------
>
> 2x2 - works
> 1x4 - works, autohiding panel with 1px proxy works
>
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104073/">http://git.reviewboard.kde.org/r/104073/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 25th, 2012, 12:03 a.m., <b>Philip \
Turmel</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Did not work in 1x4 with virtualbox. Mouse flickered between vbox style \
and kwin style at the edge. Vbox mini-toolbar would not pop down.
I don't know how to debug in more detail, but I did review the diff. I'm \
concerned that your changes to ScreenEdge::reserveDesktopSwitching() are not \
maintaining the balance of reserve vs. unreserve counts. Reservation is not a \
boolean property.
Also, as can be seen in my competing patch, the information needed to \
reserve/unreserve just the needed edges is accessible from within the routines that \
need it, without an API change.
Finally, this solution doesn't appear to examine the ignore/follow pager layout \
setting from the effects, and therefore doesn't offer the functionality I've \
requested. I'm aware that isn't universally desired, but I can't \
recommend your solution if it doesn't address my needs.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The API change is there \
because geometry.cpp needs to allocate all borders when moving a window \
(maximization, quick tiling etc.) and is no problem at all. We don't need ABI \
stability in the core and it's preserved by the effect lib (where ABI is usually \
but not necessarily preserved in minor versions) the same way as you do - by not \
exporting the function, resp. not changing the signature (that is not necessary)
The ignore/follow pager is no global setting but provided by some effects \
independently. Now, if you want to allow ignoring the layout, the entire setting \
should just go and be replaced by adding next/prev resp. up/down/left/right hooks to \
each border since that is what it would become.
However and as mentioned in the bug my opinion remains that particular pagers may \
deviate from the generally set layout regarding their particular needs or options. A \
general ignore option thus makes hardly sense and ignoring it here should better be \
done by breaking up the borders and removing ::reserveDesktopSwitching() \
altogether</pre> <br />
<p>- Thomas</p>
<br />
<p>On February 25th, 2012, 1:49 a.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Martin Gräßlin and Philip Turmel.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Feb. 25, 2012, 1:49 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In competition to http://git.reviewboard.kde.org/r/104070/ This only \
reserves the electric borders that are actually required, depending on the configured \
desktop matrix.
I tested, but Philip should best try VBox as well</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">2x2 - works 1x4 - works, autohiding panel with 1px proxy works</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=293011">293011</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/desktoplayout.cpp <span style="color: grey">(7578559)</span></li>
<li>kwin/effects.h <span style="color: grey">(f4ad2fb)</span></li>
<li>kwin/effects.cpp <span style="color: grey">(6c252c9)</span></li>
<li>kwin/geometry.cpp <span style="color: grey">(d9ae97a)</span></li>
<li>kwin/libkwineffects/kwineffects.h <span style="color: \
grey">(780cc89)</span></li>
<li>kwin/scene.cpp <span style="color: grey">(0541198)</span></li>
<li>kwin/screenedge.h <span style="color: grey">(cf08164)</span></li>
<li>kwin/screenedge.cpp <span style="color: grey">(9734a1e)</span></li>
<li>kwin/workspace.h <span style="color: grey">(d5942dc)</span></li>
<li>kwin/workspace.cpp <span style="color: grey">(b4fd277)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104073/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic