This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103975/

kwin/activation.cpp (Diff revision 2) 
bool Workspace::activateNextClient(Client* c)
440 
        while (it != stackingOrder().constBegin()) {
 459 
        if (get_focus == c || get_focus->isDesktop()) {
 
this leads to crashes on logouts since get_window is NULL at a time, fixed for commit but am out of branch again and have not found a way to convince reviewboard to accept patches with "wrong" index. *shrug*

- Thomas


On February 16th, 2012, 10:47 p.m., Thomas Lübking wrote:

Review request for kwin and Martin Gräßlin.
By Thomas Lübking.

Updated Feb. 16, 2012, 10:47 p.m.

Description 

Added clientUnderMouse() -used as well by nextFocusPrefesrMouse- and pass the focus there when lowered by mouseclick.
No idea whether it should apply to toggle as well (esp. not activating because of raising)

Testing 

Yes - I hope nextFocusPrefersMouse remains working ;-)
Bugs: 255052

Diffs

  • kwin/activation.cpp (37f0070)
  • kwin/useractions.cpp (b310a39)
  • kwin/workspace.h (092b6a7)

View Diff