'Review Request: Don't allocate m_closeview if unused and guard it's pointers'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Review Request: Don't allocate m_closeview if unused and guard it's pointers
From:       Thomas_Lübking <thomas.luebking () web ! de>
Date:       2012-02-17 19:56:54
Message-ID: 20120217195654.30444.17044 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104009/
-----------------------------------------------------------

Review request for kwin and Martin Gräßlin.

Description
-------

a) because it's not used anyway and i've no idea about plasma's cache strategy, but \
allocating it frankly causes quite some I/O activity here every now and then... \
(what's really nasty if the HDD is loaded otherwise, and yes: with running plasma \
desktop - w/o major desktop-full-of-stuff, though) b) by not doing so and disabling \
it and running present windows i could easily guard it's accesses - and we used to \
get invalid accesses on it every not and then, so no they're guarded =)

Diffs
-----

  kwin/effects/presentwindows/presentwindows.cpp fc725d9 

Diff: http://git.reviewboard.kde.org/r/104009/diff/

Testing
-------

Yes, present windows w/o closeviews acts as expected and activating them from the \
config dialog does as well.

Thanks,

Thomas Lübking

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104009/">http://git.reviewboard.kde.org/r/104009/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">a) because it&#39;s not used anyway and i&#39;ve no idea about \
plasma&#39;s cache strategy, but allocating it frankly causes quite some I/O activity \
here every now and then... (what&#39;s really nasty if the HDD is loaded otherwise, \
and yes: with running plasma desktop - w/o major desktop-full-of-stuff, though) b) by \
not doing so and disabling it and running present windows i could easily guard \
it&#39;s accesses - and we used to get invalid accesses on it every not and then, so \
no they&#39;re guarded =)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes, present windows w/o closeviews acts as expected and activating them \
from the config dialog does as well.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/effects/presentwindows/presentwindows.cpp <span style="color: \
grey">(fc725d9)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104009/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 