[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Review Request: Select proper client for the shortcut slots and guard the pointer
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2012-02-16 22:52:30
Message-ID: 20120216225230.21174.97218 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103998/
-----------------------------------------------------------
Review request for kwin and Martin Gr=C3=A4=C3=9Flin.
Description
-------
The slots are bound to the shortcuts, not the popup (this might be a relict=
from KDE3 times) so active_popup_client is wrong in this case.
Also active_client can be NULL any time, so it's required to guard it. The =
dock/desktop test should actually be done on a deeper level, but it won't h=
arm to apply it here as well and it can -thanks to a define- be easily remo=
ved here later.
Diffs
-----
kwin/useractions.cpp b310a39 =
Diff: http://git.reviewboard.kde.org/r/103998/diff/
Testing
-------
Window shortcuts (tested some) and popup actions (tested all) still work
Thanks,
Thomas L=C3=BCbking
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103998/">http://git.reviewboard.kde.org/r/103998/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The slots are bound to the shortcuts, not the popup (this might be a \
relict from KDE3 times) so active_popup_client is wrong in this case. Also \
active_client can be NULL any time, so it's required to guard it. The \
dock/desktop test should actually be done on a deeper level, but it won't harm to \
apply it here as well and it can -thanks to a define- be easily removed here \
later.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Window shortcuts (tested some) and popup actions (tested all) still \
work</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/useractions.cpp <span style="color: grey">(b310a39)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103998/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic